Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: build/config/ios/rules.gni

Issue 1948753002: [GN] Cleanup workaround in build/config/ios/rules.gni. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-gen-xcode
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/mac/base_rules.gni") 5 import("//build/config/mac/base_rules.gni")
6 6
7 # Generates Info.plist files for Mac apps and frameworks. 7 # Generates Info.plist files for Mac apps and frameworks.
8 # 8 #
9 # Arguments 9 # Arguments
10 # 10 #
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 data_deps = [] 165 data_deps = []
166 } 166 }
167 data_deps += [ "//testing/iossim" ] 167 data_deps += [ "//testing/iossim" ]
168 } 168 }
169 169
170 product_type = "com.apple.product-type.application" 170 product_type = "com.apple.product-type.application"
171 bundle_root_dir = "$root_out_dir/$_output_name.app" 171 bundle_root_dir = "$root_out_dir/$_output_name.app"
172 bundle_resources_dir = bundle_root_dir 172 bundle_resources_dir = bundle_root_dir
173 bundle_executable_dir = bundle_root_dir 173 bundle_executable_dir = bundle_root_dir
174 bundle_plugins_dir = "$bundle_root_dir/Plugins" 174 bundle_plugins_dir = "$bundle_root_dir/Plugins"
175 assert(
176 product_type != "",
177 "workaround to allow generation with version of gn that don't support pr oduct_type property for create_bundle target => remove once gn has rolled this c hange")
178 } 175 }
179 176
180 # TODO(crbug.com/297668): 177 # TODO(crbug.com/297668):
181 # - add support for codesigning, 178 # - add support for codesigning,
182 # - find a way to make "ninja -C out/Default base_unittests.app" work as 179 # - find a way to make "ninja -C out/Default base_unittests.app" work as
183 # an alias to "ninja -C out/Default base_unittests" (for convenience 180 # an alias to "ninja -C out/Default base_unittests" (for convenience
184 # and compatibility with gyp), 181 # and compatibility with gyp),
185 } 182 }
186 183
187 # Compile a xib or storyboard file and add it to a bundle_data so that it is 184 # Compile a xib or storyboard file and add it to a bundle_data so that it is
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 [ 420 [
424 "testonly", 421 "testonly",
425 "visibility", 422 "visibility",
426 ]) 423 ])
427 public_deps = [ 424 public_deps = [
428 ":$_framework_target+link", 425 ":$_framework_target+link",
429 ] 426 ]
430 } 427 }
431 } 428 }
432 } 429 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698