Revert of Create and integrate a metrics service client into Blimp engine.

Revert of Create and integrate a metrics service client into Blimp engine. (patchset #13 id:240001 of https://codereview.chromium.org/1885673003/ )

Reason for revert:
Detected engine crash.  Looks like a PerfService lifetime issue.

Original issue's description:
> Create and integrate a metrics service client into Blimp engine.
>
> This will allow Blimp to collect and upload metrics to aid in
> development.
>
> BUG=592757
>
> Committed: https://crrev.com/0be9daea216b9144830da20bcb3e2a56591207e6
> Cr-Commit-Position: refs/heads/master@{#391360}

TBR=wez@chromium.org,battre@chromium.org,bauerb@chromium.org,asvitkine@chromium.org,kmarshall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=592757
Committed: https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a
Cr-Commit-Position: refs/heads/master@{#391462}

[Jess, 2016-05-03 23:47:24]

Created Revert of Create and integrate a metrics service client into Blimp
engine.

[commit-bot: I haz the power, 2016-05-03 23:48:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948733003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948733003/1

[commit-bot: I haz the power, 2016-05-03 23:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 23:49:01]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Jess, 2016-05-03 23:50:43]

Description was changed from

==========
Revert of Create and integrate a metrics service client into Blimp engine.
(patchset #13 id:240001 of https://codereview.chromium.org/1885673003/ )

Reason for revert:
Detected engine crash.  Looks like a PerfService lifetime issue.

Original issue's description:
> Create and integrate a metrics service client into Blimp engine.
> 
> This will allow Blimp to collect and upload metrics to aid in
> development.
> 
> BUG=592757
> 
> Committed: https://crrev.com/0be9daea216b9144830da20bcb3e2a56591207e6
> Cr-Commit-Position: refs/heads/master@{#391360}

TBR=wez@chromium.org,battre@chromium.org,bauerb@chromium.org,asvitkine@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=592757
==========

to

==========
Revert of Create and integrate a metrics service client into Blimp engine.
(patchset #13 id:240001 of https://codereview.chromium.org/1885673003/ )

Reason for revert:
Detected engine crash.  Looks like a PerfService lifetime issue.

Original issue's description:
> Create and integrate a metrics service client into Blimp engine.
> 
> This will allow Blimp to collect and upload metrics to aid in
> development.
> 
> BUG=592757
> 
> Committed: https://crrev.com/0be9daea216b9144830da20bcb3e2a56591207e6
> Cr-Commit-Position: refs/heads/master@{#391360}

TBR=wez@chromium.org,battre@chromium.org,bauerb@chromium.org,asvitkine@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=592757
==========

[Jess, 2016-05-03 23:51:59]

Hey Kevin, etc.

Please forward this to the commit queue if this is blocking.  Unfortunately
there are no committers locally to lgtm.

[Jess, 2016-05-03 23:52:00]

Hey Kevin, etc.

Please forward this to the commit queue if this is blocking.  Unfortunately
there are no committers locally to lgtm.

[Bernhard Bauer, 2016-05-04 08:45:44]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2016-05-04 08:45:44]

lgtm

[commit-bot: I haz the power, 2016-05-04 08:45:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948733003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948733003/1

[commit-bot: I haz the power, 2016-05-04 08:46:25]

Description was changed from

==========
Revert of Create and integrate a metrics service client into Blimp engine.
(patchset #13 id:240001 of https://codereview.chromium.org/1885673003/ )

Reason for revert:
Detected engine crash.  Looks like a PerfService lifetime issue.

Original issue's description:
> Create and integrate a metrics service client into Blimp engine.
> 
> This will allow Blimp to collect and upload metrics to aid in
> development.
> 
> BUG=592757
> 
> Committed: https://crrev.com/0be9daea216b9144830da20bcb3e2a56591207e6
> Cr-Commit-Position: refs/heads/master@{#391360}

TBR=wez@chromium.org,battre@chromium.org,bauerb@chromium.org,asvitkine@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=592757
==========

to

==========
Revert of Create and integrate a metrics service client into Blimp engine.
(patchset #13 id:240001 of https://codereview.chromium.org/1885673003/ )

Reason for revert:
Detected engine crash.  Looks like a PerfService lifetime issue.

Original issue's description:
> Create and integrate a metrics service client into Blimp engine.
> 
> This will allow Blimp to collect and upload metrics to aid in
> development.
> 
> BUG=592757
> 
> Committed: https://crrev.com/0be9daea216b9144830da20bcb3e2a56591207e6
> Cr-Commit-Position: refs/heads/master@{#391360}

TBR=wez@chromium.org,battre@chromium.org,bauerb@chromium.org,asvitkine@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=592757
==========

[commit-bot: I haz the power, 2016-05-04 08:46:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-04 08:47:45]

Description was changed from

==========
Revert of Create and integrate a metrics service client into Blimp engine.
(patchset #13 id:240001 of https://codereview.chromium.org/1885673003/ )

Reason for revert:
Detected engine crash.  Looks like a PerfService lifetime issue.

Original issue's description:
> Create and integrate a metrics service client into Blimp engine.
> 
> This will allow Blimp to collect and upload metrics to aid in
> development.
> 
> BUG=592757
> 
> Committed: https://crrev.com/0be9daea216b9144830da20bcb3e2a56591207e6
> Cr-Commit-Position: refs/heads/master@{#391360}

TBR=wez@chromium.org,battre@chromium.org,bauerb@chromium.org,asvitkine@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=592757
==========

to

==========
Revert of Create and integrate a metrics service client into Blimp engine.
(patchset #13 id:240001 of https://codereview.chromium.org/1885673003/ )

Reason for revert:
Detected engine crash.  Looks like a PerfService lifetime issue.

Original issue's description:
> Create and integrate a metrics service client into Blimp engine.
>
> This will allow Blimp to collect and upload metrics to aid in
> development.
>
> BUG=592757
>
> Committed: https://crrev.com/0be9daea216b9144830da20bcb3e2a56591207e6
> Cr-Commit-Position: refs/heads/master@{#391360}

TBR=wez@chromium.org,battre@chromium.org,bauerb@chromium.org,asvitkine@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=592757

Committed: https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a
Cr-Commit-Position: refs/heads/master@{#391462}
==========

[commit-bot: I haz the power, 2016-05-04 08:47:46]

Patchset 1 (id:??) landed as
https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a
Cr-Commit-Position: refs/heads/master@{#391462}

[Wez, 2016-05-04 10:57:28]

In future if you are reverting your own CL due to it causing failures, you
can TBR= the original reviewers rather than leaving the tree in a bad state
waiting for rubber-stamp lgtms.
On 4 May 2016 09:47, "commit-bot@chromium.org via codereview.chromium.org" <
reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a
> Cr-Commit-Position: refs/heads/master@{#391462}
>
> https://codereview.chromium.org/1948733003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jess, 2016-05-04 16:26:03]

On 2016/05/04 10:57:28, Wez wrote:
> In future if you are reverting your own CL due to it causing failures, you
> can TBR= the original reviewers rather than leaving the tree in a bad state
> waiting for rubber-stamp lgtms.
> On 4 May 2016 09:47, mailto:"commit-bot@chromium.org via
codereview.chromium.org" <
> mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote:
> 
> > Patchset 1 (id:??) landed as
> > https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a
> > Cr-Commit-Position: refs/heads/master@{#391462}
> >
> > https://codereview.chromium.org/1948733003/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I am not a committer. Would that still work?

[Wez, 2016-05-04 16:58:51]

Committees vs OWNERS are two different things; TBR let's you postpone the
owners check, so you just need an LGTM from any Chromium committer to land,
if you're not one yourself yet.
On 4 May 2016 17:26, <jessicag@chromium.org> wrote:

> On 2016/05/04 10:57:28, Wez wrote:
> > In future if you are reverting your own CL due to it causing failures,
> you
> > can TBR= the original reviewers rather than leaving the tree in a bad
> state
> > waiting for rubber-stamp lgtms.
> > On 4 May 2016 09:47, mailto:"commit-bot@chromium.org via
> codereview.chromium.org" <
> > mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote:
> >
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a
> > > Cr-Commit-Position: refs/heads/master@{#391462}
> > >
> > > https://codereview.chromium.org/1948733003/
> > >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
>
> I am not a committer. Would that still work?
>
> https://codereview.chromium.org/1948733003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[maniscalco, 2016-05-04 17:23:56]

Right, TBR alone would not have helped.

On 2016/05/04 16:58:51, Wez wrote:
> Committees vs OWNERS are two different things; TBR let's you postpone the
> owners check, so you just need an LGTM from any Chromium committer to land,
> if you're not one yourself yet.
> On 4 May 2016 17:26, <mailto:jessicag@chromium.org> wrote:
> 
> > On 2016/05/04 10:57:28, Wez wrote:
> > > In future if you are reverting your own CL due to it causing failures,
> > you
> > > can TBR= the original reviewers rather than leaving the tree in a bad
> > state
> > > waiting for rubber-stamp lgtms.
> > > On 4 May 2016 09:47, mailto:"commit-bot@chromium.org via
> > codereview.chromium.org" <
> > > mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote:
> > >
> > > > Patchset 1 (id:??) landed as
> > > > https://crrev.com/cb3bd1e8780cdd8d87ceb617a5b804607ed9098a
> > > > Cr-Commit-Position: refs/heads/master@{#391462}
> > > >
> > > > https://codereview.chromium.org/1948733003/
> > > >
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Chromium-reviews" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an
> > email
> > > to mailto:chromium-reviews+unsubscribe@chromium.org.
> >
> > I am not a committer. Would that still work?
> >
> > https://codereview.chromium.org/1948733003/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.