Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3166)

Unified Diff: blimp/engine/common/blimp_browser_context.cc

Issue 1948733003: Revert of Create and integrate a metrics service client into Blimp engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/common/blimp_browser_context.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/common/blimp_browser_context.cc
diff --git a/blimp/engine/common/blimp_browser_context.cc b/blimp/engine/common/blimp_browser_context.cc
index b5c8294a16a55534d133bf37358f9fa35fc53256..6a2a7ec04ad9ba83d257b766bf9ef850515804b0 100644
--- a/blimp/engine/common/blimp_browser_context.cc
+++ b/blimp/engine/common/blimp_browser_context.cc
@@ -7,26 +7,13 @@
#include "base/bind.h"
#include "base/environment.h"
#include "base/files/file_util.h"
-#include "base/memory/ptr_util.h"
#include "base/nix/xdg_util.h"
#include "base/path_service.h"
#include "blimp/engine/app/blimp_permission_manager.h"
-#include "components/metrics/metrics_service.h"
-#include "components/pref_registry/pref_registry_syncable.h"
-#include "components/prefs/in_memory_pref_store.h"
-#include "components/prefs/pref_service.h"
-#include "components/prefs/pref_service_factory.h"
#include "content/public/browser/background_sync_controller.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/common/content_switches.h"
-
-namespace {
-// Function for optionally handling read errors. Is a no-op for Blimp.
-// While the PersistentPrefStore's interface is supported, it is an in-memory
-// store only.
-void IgnoreReadError(PersistentPrefStore::PrefReadError error) {}
-} // namespace
namespace blimp {
namespace engine {
@@ -72,11 +59,9 @@
off_the_record_(off_the_record),
net_log_(net_log) {
InitWhileIOAllowed();
- InitializeBlimpMetrics(GetPrefService(), GetSystemRequestContextGetter());
}
BlimpBrowserContext::~BlimpBrowserContext() {
- FinalizeBlimpMetrics();
if (resource_context_) {
content::BrowserThread::DeleteSoon(content::BrowserThread::IO, FROM_HERE,
resource_context_.release());
@@ -92,22 +77,6 @@
if (!base::PathExists(path_))
base::CreateDirectory(path_);
BrowserContext::Initialize(this, path_);
-}
-
-std::unique_ptr<PrefService> BlimpBrowserContext::GetPrefService() {
- // Create PrefRegistry and register metrics services preferences with it.
- scoped_refptr<user_prefs::PrefRegistrySyncable> pref_registry(
- new user_prefs::PrefRegistrySyncable());
- metrics::MetricsService::RegisterPrefs(pref_registry.get());
- PrefServiceFactory pref_service_factory;
-
- // Create an in memory preferences store to hold metrics logs.
- pref_service_factory.set_user_prefs(new InMemoryPrefStore());
- pref_service_factory.set_read_error_callback(base::Bind(&IgnoreReadError));
-
- // Create a PrefService binding the PrefRegistry to the InMemoryPrefStore.
- // The PrefService ends up owning the PrefRegistry and the InMemoryPrefStore.
- return pref_service_factory.Create(pref_registry.get());
}
std::unique_ptr<content::ZoomLevelDelegate>
« no previous file with comments | « blimp/engine/common/blimp_browser_context.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698