Mac software video: Use AVSampleBufferDisplayLayer

Mac software video: Use AVSampleBufferDisplayLayer

Also specify a default color profile for 420v IOSurfaces, because there
are bugs when no color profile is specified.

BUG=594449
Committed: https://crrev.com/4d1b92ff111856df2474c8f3f6c6814f228c965c
Cr-Commit-Position: refs/heads/master@{#391893}

[ccameron, 2016-05-03 20:58:02]

ccameron@chromium.org changed reviewers:
+ erikchen@chromium.org

[ccameron, 2016-05-03 20:58:03]

Seems appropriate to add this now, since h264 has been using
AVSampleBufferDisplayLayer has been using this for a while with no issues.

[ccameron, 2016-05-04 18:05:37]

ping

[erikchen, 2016-05-04 18:14:46]

https://codereview.chromium.org/1948723002/diff/20001/ui/gfx/mac/io_surface.cc
File ui/gfx/mac/io_surface.cc (right):

https://codereview.chromium.org/1948723002/diff/20001/ui/gfx/mac/io_surface.c...
ui/gfx/mac/io_surface.cc:177: CGColorSpaceCopyICCProfile(color_space));
CGColorSpaceCopyICCProfile might return NULL. I think we should not pass NULL to
 IOSurfaceSetValue. Thoughts on what we should do here?

[ccameron, 2016-05-05 18:50:01]

https://codereview.chromium.org/1948723002/diff/20001/ui/gfx/mac/io_surface.cc
File ui/gfx/mac/io_surface.cc (right):

https://codereview.chromium.org/1948723002/diff/20001/ui/gfx/mac/io_surface.c...
ui/gfx/mac/io_surface.cc:177: CGColorSpaceCopyICCProfile(color_space));
On 2016/05/04 18:14:45, erikchen wrote:
> CGColorSpaceCopyICCProfile might return NULL. I think we should not pass NULL
to
>  IOSurfaceSetValue. Thoughts on what we should do here?

I tested passing NULL to IOSurfaceSetValue, and it appears to have no effect
(certainly doesn't cause problems).

Alternatively, we could just send something like sRGB (which will reliably have
a profile)

Soon, hopefully, we'll have an API set up to pass the correct color space.

[erikchen, 2016-05-05 19:11:55]

lgtm

https://codereview.chromium.org/1948723002/diff/20001/ui/gfx/mac/io_surface.cc
File ui/gfx/mac/io_surface.cc (right):

https://codereview.chromium.org/1948723002/diff/20001/ui/gfx/mac/io_surface.c...
ui/gfx/mac/io_surface.cc:177: CGColorSpaceCopyICCProfile(color_space));
On 2016/05/05 18:50:01, ccameron wrote:
> On 2016/05/04 18:14:45, erikchen wrote:
> > CGColorSpaceCopyICCProfile might return NULL. I think we should not pass
NULL
> to
> >  IOSurfaceSetValue. Thoughts on what we should do here?
> 
> I tested passing NULL to IOSurfaceSetValue, and it appears to have no effect
> (certainly doesn't cause problems).
> 
> Alternatively, we could just send something like sRGB (which will reliably
have
> a profile)
> 
> Soon, hopefully, we'll have an API set up to pass the correct color space.

Ok, just add a comment about NULL a valid parameter.

[ccameron, 2016-05-05 19:29:45]

Done -- thanks!

[ccameron, 2016-05-05 19:29:48]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-05-05 19:29:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1948723002/#ps40001
(title: "IRF")

[commit-bot: I haz the power, 2016-05-05 19:30:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948723002/40001

[commit-bot: I haz the power, 2016-05-05 20:26:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-05 20:27:29]

Description was changed from

==========
Mac software video: Use AVSampleBufferDisplayLayer

Also specify a default color profile for 420v IOSurfaces, because there
are bugs when no color profile is specified.

BUG=594449
==========

to

==========
Mac software video: Use AVSampleBufferDisplayLayer

Also specify a default color profile for 420v IOSurfaces, because there
are bugs when no color profile is specified.

BUG=594449

Committed: https://crrev.com/4d1b92ff111856df2474c8f3f6c6814f228c965c
Cr-Commit-Position: refs/heads/master@{#391893}
==========

[commit-bot: I haz the power, 2016-05-05 20:27:30]

Patchset 3 (id:??) landed as
https://crrev.com/4d1b92ff111856df2474c8f3f6c6814f228c965c
Cr-Commit-Position: refs/heads/master@{#391893}