Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

Issue 1948723002: Mac software video: Use AVSampleBufferDisplayLayer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IRF Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/mac/io_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
diff --git a/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm b/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
index 204556a1343bc42455948812847ee81463d78ba5..feb283eaadef2ef7e1d03120c8ec30f6f2918364 100644
--- a/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
+++ b/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
@@ -327,11 +327,7 @@ CARendererLayerTree::ContentLayer::ContentLayer(
if (IOSurfaceGetPixelFormat(io_surface) ==
kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange &&
contents_rect == gfx::RectF(0, 0, 1, 1)) {
- // Enable only for hardware decoded frames, to see if flashing bugs are
- // particular to software IOSurfaces.
- // https://crbug.com/598269
- if (cv_pixel_buffer)
- use_av_layer = true;
+ use_av_layer = true;
}
}
@@ -649,15 +645,15 @@ void CARendererLayerTree::ContentLayer::CommitToCA(CALayer* superlayer,
base::ScopedCFTypeRef<CGColorRef> color;
if (update_anything) {
if (use_av_layer) {
- // Green represents an AV layer that changed this frame.
- color.reset(CGColorCreateGenericRGB(0, 1, 0, 1));
+ // Yellow represents an AV layer that changed this frame.
+ color.reset(CGColorCreateGenericRGB(1, 1, 0, 1));
} else {
// Pink represents a CALayer that changed this frame.
color.reset(CGColorCreateGenericRGB(1, 0, 1, 1));
}
} else {
// Grey represents a CALayer that has not changed.
- color.reset(CGColorCreateGenericRGB(0, 0, 0, 0.1));
+ color.reset(CGColorCreateGenericRGB(0.5, 0.5, 0.5, 1));
}
[ca_layer setBorderWidth:1];
[ca_layer setBorderColor:color];
« no previous file with comments | « no previous file | ui/gfx/mac/io_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698