Mac software video: Use AVSampleBufferDisplayLayer

ui/gfx/mac/io_surface.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/mac/io_surface.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/logging.h"
@@ skipping 146 matching lines @@
   // https://crbug.com/594343.
   if (!base::mac::IsOSMavericks()) {
     // Zero-initialize the IOSurface. Calling IOSurfaceLock/IOSurfaceUnlock
     // appears to be sufficient. https://crbug.com/584760#c17
     IOReturn r = IOSurfaceLock(surface, 0, nullptr);
     DCHECK_EQ(kIOReturnSuccess, r);
     r = IOSurfaceUnlock(surface, 0, nullptr);
     DCHECK_EQ(kIOReturnSuccess, r);
   }
 
+  // Displaying an IOSurface that does not have a color space using an
+  // AVSampleBufferDisplayLayer can result in a black screen. Specify the
+  // main display's color profile by default, which will result in no color
+  // correction being done for the main monitor (which is the behavior of not
+  // specifying a color space).
+  // https://crbug.com/608879
+  if (format == gfx::BufferFormat::YUV_420_BIPLANAR) {
+    base::ScopedCFTypeRef<CGColorSpaceRef> color_space(
+        CGDisplayCopyColorSpace(CGMainDisplayID()));
+    base::ScopedCFTypeRef<CFDataRef> color_space_icc(
+        CGColorSpaceCopyICCProfile(color_space));

[erikchen, 2016/05/04 18:14:45]

CGColorSpaceCopyICCProfile might return NULL. I think we should not pass NULL to
 IOSurfaceSetValue. Thoughts on what we should do here?

[ccameron, 2016/05/05 18:50:01]

I tested passing NULL to IOSurfaceSetValue, and it appears to have no effect
(certainly doesn't cause problems).

Alternatively, we could just send something like sRGB (which will reliably have
a profile)

Soon, hopefully, we'll have an API set up to pass the correct color space.

[erikchen, 2016/05/05 19:11:55]

Ok, just add a comment about NULL a valid parameter.

+    IOSurfaceSetValue(surface, CFSTR("IOSurfaceColorSpace"), color_space_icc);
+  }
+
   return surface;
 }
 
 }  // namespace gfx