Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1948223003: 💦Rename libmonochrome target to monochrome. (Closed)

Created:
4 years, 7 months ago by Yaron
Modified:
4 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename libmonochrome target to monochrome. Matches new name in https://codereview.chromium.org/1948503002 BUG=607207 Committed: https://crrev.com/a1fc8781e1485d18cd928b9f98853af41ff8bc0c Cr-Commit-Position: refs/heads/master@{#391833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Yaron
4 years, 7 months ago (2016-05-05 14:12:01 UTC) #3
Torne
Is this just a cleanup or does this have to be changed to keep the ...
4 years, 7 months ago (2016-05-05 14:23:06 UTC) #4
Yaron
On 2016/05/05 14:23:06, Torne wrote: > Is this just a cleanup or does this have ...
4 years, 7 months ago (2016-05-05 14:25:51 UTC) #5
Torne
lgtm
4 years, 7 months ago (2016-05-05 14:27:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948223003/1
4 years, 7 months ago (2016-05-05 16:57:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 17:01:46 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 17:03:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1fc8781e1485d18cd928b9f98853af41ff8bc0c
Cr-Commit-Position: refs/heads/master@{#391833}

Powered by Google App Engine
This is Rietveld 408576698