Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1965953002: 🌒 Remove support for split apks. (Closed)

Created:
4 years, 7 months ago by Yaron
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for split apks. Sadly these never panned out and are causing issues for WebApks. BUG=609122 Committed: https://crrev.com/94c3716855e471c0b9d49b345320d87e86ffcd6b Cr-Commit-Position: refs/heads/master@{#393254}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -76 lines) Patch
M base/android/build_info.h View 2 chunks +0 lines, -5 lines 0 comments Download
M base/android/build_info.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/android/java/src/org/chromium/base/BuildInfo.java View 2 chunks +0 lines, -18 lines 0 comments Download
M base/android/java/src/org/chromium/base/PackageUtils.java View 1 chunk +0 lines, -18 lines 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 3 chunks +1 line, -25 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 2 chunks +1 line, -4 lines 0 comments Download

Depends on Patchset:

Issue 1948223003 Patch 1

Messages

Total messages: 13 (6 generated)
Yaron
thestig: chrome/browser/chrome_browser_main_android.cc agrieve: everything
4 years, 7 months ago (2016-05-10 19:52:47 UTC) #3
Lei Zhang
chrome/ lgtm https://codereview.chromium.org/1965953002/diff/1/chrome/browser/chrome_browser_main_android.cc File chrome/browser/chrome_browser_main_android.cc (left): https://codereview.chromium.org/1965953002/diff/1/chrome/browser/chrome_browser_main_android.cc#oldcode76 chrome/browser/chrome_browser_main_android.cc:76: base::android::BuildInfo::GetInstance()->has_language_apk_splits(); Remove the base/android/build_info.h include as well?
4 years, 7 months ago (2016-05-10 20:30:21 UTC) #4
agrieve
le sigh (lgtm)
4 years, 7 months ago (2016-05-12 00:45:47 UTC) #5
Yaron
https://codereview.chromium.org/1965953002/diff/1/chrome/browser/chrome_browser_main_android.cc File chrome/browser/chrome_browser_main_android.cc (left): https://codereview.chromium.org/1965953002/diff/1/chrome/browser/chrome_browser_main_android.cc#oldcode76 chrome/browser/chrome_browser_main_android.cc:76: base::android::BuildInfo::GetInstance()->has_language_apk_splits(); On 2016/05/10 20:30:21, Lei Zhang wrote: > Remove ...
4 years, 7 months ago (2016-05-12 14:26:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965953002/20001
4 years, 7 months ago (2016-05-12 14:26:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 15:29:08 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 15:30:18 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/94c3716855e471c0b9d49b345320d87e86ffcd6b
Cr-Commit-Position: refs/heads/master@{#393254}

Powered by Google App Engine
This is Rietveld 408576698