Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1947983006: ☯ Remove deprecated libchrome_public target. (Closed)

Created:
4 years, 7 months ago by Yaron
Modified:
4 years, 7 months ago
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated libchrome_public target. Now that all C++ code is opensource, there's no need for a libchrome_public shared library. ChromePublic can just use libchrome. BUG=607207 Committed: https://crrev.com/064343a4381a0260adb445affb50a063b921e168 Cr-Commit-Position: refs/heads/master@{#392056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M base/allocator/allocator_shim_override_linker_wrapped_symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +2 lines, -12 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 5 chunks +6 lines, -7 lines 0 comments Download
M infra/scripts/legacy/scripts/slave/chromium/sizes.py View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Yaron
phajdan.jr: infra/ primiano: the rest
4 years, 7 months ago (2016-05-05 21:13:29 UTC) #3
Primiano Tucci (use gerrit)
On 2016/05/05 21:13:29, Yaron wrote: > phajdan.jr: infra/ > primiano: the rest May the force ...
4 years, 7 months ago (2016-05-06 09:56:05 UTC) #4
Paweł Hajdan Jr.
infra LGTM
4 years, 7 months ago (2016-05-06 10:21:06 UTC) #5
Yaron
On 2016/05/06 10:21:06, Paweł Hajdan Jr. wrote: > infra LGTM Ya, I don't get it ...
4 years, 7 months ago (2016-05-06 14:00:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947983006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947983006/1
4 years, 7 months ago (2016-05-06 14:00:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 14:29:08 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 14:30:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/064343a4381a0260adb445affb50a063b921e168
Cr-Commit-Position: refs/heads/master@{#392056}

Powered by Google App Engine
This is Rietveld 408576698