Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1948023002: triggering: add critical flag (Closed)

Created:
4 years, 7 months ago by nodir
Modified:
4 years, 6 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
git@github.com:luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

triggering: add critical flag Pipe "critical" flag in triggering spec. If it is set and triggering fails asynchronously, the build is failed. Triggering is critical by default R=martiniss@chromium.org BUG=609166 Committed: https://github.com/luci/recipes-py/commit/866db4322e55e91efbef9fcff02b188cceba8df3

Patch Set 1 #

Total comments: 1

Patch Set 2 : do not print <br> in step text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M recipe_engine/run.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nodir
PTAL
4 years, 7 months ago (2016-05-04 17:20:50 UTC) #2
nodir
https://codereview.chromium.org/1948023002/diff/1/recipe_engine/step_runner.py File recipe_engine/step_runner.py (right): https://codereview.chromium.org/1948023002/diff/1/recipe_engine/step_runner.py#newcode338 recipe_engine/step_runner.py:338: # if True and triggering fails asynchronously, fail entire ...
4 years, 7 months ago (2016-05-04 17:28:13 UTC) #3
nodir
ping
4 years, 7 months ago (2016-05-09 15:40:18 UTC) #4
martiniss
lgtm
4 years, 7 months ago (2016-05-09 22:37:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948023002/1
4 years, 7 months ago (2016-05-09 22:47:04 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 22:49:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/866db4322e55e91efbef9fcff02b188cceb...

Powered by Google App Engine
This is Rietveld 408576698