triggering: add critical flag

recipe_engine/step_runner.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import cStringIO
 import collections
 import contextlib
 import datetime
 import json
 import os
@@ skipping 25 matching lines @@
 
   def open_step(self, step_dict):
     """Constructs an OpenStep object which can be used to actually run a step.
 
     step_dict parameters:
       name: name of the step, will appear in buildbots waterfall
       cmd: command to run, list of one or more strings
       cwd: absolute path to working directory for the command
       env: dict with overrides for environment variables
       allow_subannotations: if True, lets the step emit its own annotations
-      trigger_specs: a list of trigger specifications, which are dict with keys:
-          properties: a dict of properties.
-              Buildbot requires buildername property.
+      trigger_specs: a list of trigger specifications, see also _trigger_builds.
       stdout: Path to a file to put step stdout into. If used, stdout won't
               appear in annotator's stdout (and |allow_subannotations| is
               ignored).
       stderr: Path to a file to put step stderr into. If used, stderr won't
               appear in annotator's stderr.
       stdin: Path to a file to read step stdin from.
 
     Returns an OpenStep object.
     """
     raise NotImplementedError()
@@ skipping 271 matching lines @@
         raise ValueError('Trigger spec: builder_name is not set')
 
       changes = trig.get('buildbot_changes', [])
       assert isinstance(changes, list), 'buildbot_changes must be a list'
       changes = map(self._normalize_change, changes)
 
       step.trigger(json.dumps({
           'builderNames': [builder_name],
           'bucket': trig.get('bucket'),
           'changes': changes,
+          # if True and triggering fails asynchronously, fail entire build.

[nodir, 2016/05/04 17:28:13]

implemented in https://codereview.chromium.org/1949753003/

+          'critical': trig.get('critical', True),
           'properties': trig.get('properties'),
           'tags': trig.get('tags'),
       }, sort_keys=True))
 
   def _normalize_change(self, change):
     assert isinstance(change, dict), 'Change is not a dict'
     change = change.copy()
 
     # Convert when_timestamp to UNIX timestamp.
     when = change.get('when_timestamp')
@@ skipping 262 matching lines @@
   supplied command, and only uses the |env| kwarg for modifying the environment
   of the child process.
   """
   saved_path = os.environ['PATH']
   try:
     if path is not None:
       os.environ['PATH'] = path
     yield
   finally:
     os.environ['PATH'] = saved_path