recipe_engine/run.py - Issue 1948023002: triggering: add critical flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_engine/run.py

Issue 1948023002: triggering: add critical flag (Closed) Base URL: git@github.com:luci/recipes-py.git@master

Patch Set: do not print <br> in step text Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: recipe_engine/run.py

diff --git a/recipe_engine/run.py b/recipe_engine/run.py

index 03fa3772d87cc571e1ed13af97e8ef16fea6a1e6..68c47b57d3a2812e5f8c637ccb680a1cb37255de 100644

--- a/recipe_engine/run.py

+++ b/recipe_engine/run.py

@@ -247,9 +247,10 @@ def run_steps(properties, stream_engine, step_runner, universe):

engine,

recipe_test_api.DisabledTestData())

- s.add_step_text('<br/>running recipe: "%s"' % recipe)

+ s.add_step_text('running recipe: "%s"' % recipe)

except (loader.LoaderError, ImportError, AssertionError) as e:

- s.add_step_text('<br/>%s' % '<br/>'.join(str(e).splitlines()))

+ for line in str(e).splitlines():

+ s.add_step_text(line)

s.set_step_status('EXCEPTION')

return RecipeResult({

'status_code': 2,

« no previous file with comments | « no previous file | no next file » | no next file with comments »