Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2373)

Unified Diff: chrome/android/BUILD.gn

Issue 1947983006: ☯ Remove deprecated libchrome_public target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/allocator/allocator_shim_override_linker_wrapped_symbols.h ('k') | chrome/android/chrome_apk.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index df27750a80aa26a2467aa574f2f053b90f763e28..dfbbd74b773d964c40ee52c3239864593adbc0ab 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -427,16 +427,6 @@ jinja_template_resources("chrome_sync_shell_apk_template_resources") {
variables = chrome_sync_shell_jinja_variables
}
-# GYP: //chrome/android/chrome_apk.gyp:libchrome_public
-# TODO(yfriedman): Remove and re-use chrome target.
-shared_library("chrome_public") {
- deps = [
- "//build/config/sanitizers:deps",
- "//chrome:chrome_android_core",
- ]
- sources = chrome_apk_gypi.chrome_app_native_sources
-}
-
# GYP: none
shared_library("chrome") {
sources = chrome_apk_gypi.chrome_app_native_sources
@@ -503,10 +493,10 @@ chrome_public_apk_tmpl_shared("chrome_public_apk") {
android_manifest = get_target_outputs(":chrome_public_apk_manifest")
android_manifest = android_manifest[1]
apk_name = "ChromePublic"
- native_libs = [ "libchrome_public.so" ]
+ native_libs = [ "libchrome.so" ]
deps = [
- ":chrome_public",
+ ":chrome",
":chrome_public_apk_manifest",
":chrome_public_apk_template_resources",
]
« no previous file with comments | « base/allocator/allocator_shim_override_linker_wrapped_symbols.h ('k') | chrome/android/chrome_apk.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698