Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: components/cronet/ios/empty.cc

Issue 1947903003: Cronet Dynamic Framework for iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added flag to package_ios.py that prepares Cronet dynamic framework Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/empty.cc
diff --git a/chrome/test/data/extensions/api_test/executescript/http204/at_document_end.js b/components/cronet/ios/empty.cc
similarity index 65%
copy from chrome/test/data/extensions/api_test/executescript/http204/at_document_end.js
copy to components/cronet/ios/empty.cc
index 5b0e04991e627c97943dd6628ec098aaf692abec..98d8bdf629711b0c54a45257ac7d3abe1002d6d8 100644
--- a/chrome/test/data/extensions/api_test/executescript/http204/at_document_end.js
+++ b/components/cronet/ios/empty.cc
@@ -2,4 +2,5 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-window.documentEnd = window.documentEnd ? documentEnd + 1 : 1;
+// An empty C++ file that is needed to trigger the usage of clang++ instead of
mef 2016/05/11 12:55:02 Do we still need it? This is weird.
kapishnikov 2016/05/11 19:48:15 That is the only way I found to make gyp use clang
mef 2016/05/11 20:17:19 Acknowledged. Argh! I think we can get rid of cron
+// clang.

Powered by Google App Engine
This is Rietveld 408576698