components/cronet/ios/empty.cc - Issue 1947903003: Cronet Dynamic Framework for iOS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/ios/empty.cc

Issue 1947903003: Cronet Dynamic Framework for iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added flag to package_ios.py that prepares Cronet dynamic framework Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 window.documentEnd = window.documentEnd ? documentEnd + 1 : 1;	5 // An empty C++ file that is needed to trigger the usage of clang++ instead of
	mef 2016/05/11 12:55:02 Do we still need it? This is weird. Do we still need it? This is weird. kapishnikov 2016/05/11 19:48:15 That is the only way I found to make gyp use clang Show quoted text On 2016/05/11 12:55:02, mef wrote: > Do we still need it? This is weird. That is the only way I found to make gyp use clang++. We can add a real c++ file to 'cronet_framework'; however, if the same file compiles as a part of the static library, there will be duplicate symbol error. I also tried to add 'LD': 'clang++', 'CC': 'clang++', flags to xcode_settings configuration, but it still uses clang. mef 2016/05/11 20:17:19 Acknowledged. Argh! I think we can get rid of cron Show quoted text On 2016/05/11 19:48:15, kapishnikov wrote: > On 2016/05/11 12:55:02, mef wrote: > > Do we still need it? This is weird. > > That is the only way I found to make gyp use clang++. We can add a real c++ file > to 'cronet_framework'; however, if the same file compiles as a part of the > static library, there will be duplicate symbol error. > > I also tried to add > 'LD': 'clang++', > 'CC': 'clang++', > flags to xcode_settings configuration, but it still uses clang. Acknowledged. Argh! I think we can get rid of cronet_static in near future, so this hack won't be necessary.
	6 // clang.

OLD	NEW

« components/cronet/ios/Info.plist ('K') | « components/cronet/ios/Info.plist ('k') | components/cronet/tools/package_ios.py » ('j') | components/cronet/tools/package_ios.py » ('J')