Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: components/cronet/ios/Info.plist

Issue 1947903003: Cronet Dynamic Framework for iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added flag to package_ios.py that prepares Cronet dynamic framework Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/Info.plist
diff --git a/third_party/ocmock/OCMock/OCMock-Info.plist b/components/cronet/ios/Info.plist
similarity index 64%
copy from third_party/ocmock/OCMock/OCMock-Info.plist
copy to components/cronet/ios/Info.plist
index 4bd402c317963323b2ab2928ca407bc0003e38a5..993a718b85207d2123e72d5a3f2b21c6e82937da 100644
--- a/third_party/ocmock/OCMock/OCMock-Info.plist
+++ b/components/cronet/ios/Info.plist
@@ -3,17 +3,15 @@
<plist version="1.0">
<dict>
<key>CFBundleDevelopmentRegion</key>
- <string>English</string>
+ <string>en</string>
mef 2016/05/11 12:55:02 nit: tabs -> spaces?
kapishnikov 2016/05/11 19:48:15 Done.
<key>CFBundleExecutable</key>
- <string>${EXECUTABLE_NAME}</string>
- <key>CFBundleIconFile</key>
- <string></string>
+ <string>Cronet</string>
<key>CFBundleIdentifier</key>
- <string>com.mulle-kybernetik.${PRODUCT_NAME:rfc1034identifier}</string>
+ <string>org.chromium.net.Cronet</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
- <string>${PRODUCT_NAME}</string>
+ <string>Cronet</string>
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
@@ -21,10 +19,8 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
- <string>1</string>
- <key>NSHumanReadableCopyright</key>
mef 2016/05/11 12:55:02 Put regular Chromium copyright? # Copyright 2014
kapishnikov 2016/05/11 19:48:15 Done. Used one line copyright as other components
- <string>Copyright © 2004-2011 Mulle Kybernetik.</string>
+ <string>1.0</string>
<key>NSPrincipalClass</key>
<string></string>
</dict>
-</plist>
+</plist>

Powered by Google App Engine
This is Rietveld 408576698