Site Settings Android: A few polish items.

Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.] for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753
Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}

Committed: https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b
Cr-Commit-Position: refs/heads/master@{#392899}

[Finnur, 2016-05-03 14:09:58]

Description was changed from

==========
Polish

BUG=
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).

BUG=601918, 467788, 604753
==========

[Finnur, 2016-05-03 15:59:18]

Patchset #1 (id:1) has been deleted

[Finnur, 2016-05-03 15:59:35]

Patchset #1 (id:20001) has been deleted

[Finnur, 2016-05-03 16:00:13]

Patchset #1 (id:40001) has been deleted

[Finnur, 2016-05-03 16:01:55]

Description was changed from

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).

BUG=601918, 467788, 604753
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).

Also add the Media icon, which is for the container menu that will house
Protected Content and Autoplay.

BUG=601918, 467788, 604753
==========

[Finnur, 2016-05-03 16:01:56]

finnur@chromium.org changed reviewers:
+ twellington@chromium.org

[Finnur, 2016-05-03 16:03:06]

Description was changed from

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).

Also add the Media icon, which is for the container menu that will house
Protected Content and Autoplay.

BUG=601918, 467788, 604753
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for the container menu that will house Protected Content and
Autoplay.

BUG=601918, 467788, 604753
==========

[Finnur, 2016-05-03 16:03:46]

Description was changed from

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for the container menu that will house Protected Content and
Autoplay.

BUG=601918, 467788, 604753
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753
==========

[Finnur, 2016-05-04 11:17:28]

Description was changed from

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753
==========

[Finnur, 2016-05-04 11:17:42]

Friendly ping...

[Theresa, 2016-05-04 16:33:11]

Just a couple of comments + run optimize-png-files.sh on the png's if you
haven't already.

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
(right):

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java:32:
icon.setPadding(margin, icon.getPaddingTop(), 0, icon.getPaddingBottom());
Can we use a defined dimen for the margin instead of calculating it?

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (left):

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:630: <message
name="IDS_WEBSITE_SETTINGS_CATEGORY_ASK_BEFORE_SENDING" desc="Summary text
explaining that permission will be requested before sending things, e.g.
notifications.">
I think this can get removed too. Same with
website_settings_category_ask_first_recommended.

[Finnur, 2016-05-06 15:12:44]

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
(right):

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java:32:
icon.setPadding(margin, icon.getPaddingTop(), 0, icon.getPaddingBottom());
> Can we use a defined dimen for the margin instead of calculating it?

Not sure what you mean... The setPadding param is in pixels, which means we'd
always have to calculate it to make sure it looks good on different screens.
Right? 

I've converted to using a constant, but if you have other ideas I'm open to
suggestions.

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (left):

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:630: <message
name="IDS_WEBSITE_SETTINGS_CATEGORY_ASK_BEFORE_SENDING" desc="Summary text
explaining that permission will be requested before sending things, e.g.
notifications.">
On 2016/05/04 16:33:10, Theresa Wellington wrote:
> I think this can get removed too. Same with
> website_settings_category_ask_first_recommended.

Done.

[Theresa, 2016-05-06 15:58:16]

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
(right):

https://codereview.chromium.org/1947493002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java:32:
icon.setPadding(margin, icon.getPaddingTop(), 0, icon.getPaddingBottom());
On 2016/05/06 15:12:44, Finnur wrote:
> > Can we use a defined dimen for the margin instead of calculating it?
> 
> Not sure what you mean... The setPadding param is in pixels, which means we'd
> always have to calculate it to make sure it looks good on different screens.
> Right? 
> 
> I've converted to using a constant, but if you have other ideas I'm open to
> suggestions.

Typically we use Resources.getDimensionPixelSize() to get a dp value defined in
dimens.xml.

[Finnur, 2016-05-09 13:23:45]

Patchset #6 (id:160001) has been deleted

[Finnur, 2016-05-09 13:24:32]

Fair enough. Updated. PTAL.

[Theresa, 2016-05-09 16:34:47]

lgtm

[Finnur, 2016-05-09 17:22:22]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2016-05-09 17:23:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947493002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947493002/180001

[commit-bot: I haz the power, 2016-05-09 17:31:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 17:31:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Finnur, 2016-05-09 17:40:14]

finnur@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Finnur, 2016-05-09 17:40:14]

dfalcantara@: Can you give OWNERS approval for string and image assets changing?

(And please check the CQ bit if this looks good).

[gone, 2016-05-09 17:57:45]

lgtm

[gone, 2016-05-09 17:57:50]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-05-09 17:58:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947493002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947493002/180001

[commit-bot: I haz the power, 2016-05-09 18:04:51]

Description was changed from

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753
==========

[commit-bot: I haz the power, 2016-05-09 18:04:52]

Committed patchset #6 (id:180001)

[commit-bot: I haz the power, 2016-05-09 18:08:50]

Description was changed from

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753

Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}
==========

[commit-bot: I haz the power, 2016-05-09 18:08:51]

Patchset 6 (id:??) landed as
https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}

[Finnur, 2016-05-10 15:25:13]

A revert of this CL (patchset #6 id:180001) has been created in
https://codereview.chromium.org/1968503002/ by finnur@chromium.org.

The reason for reverting is: Caused crbug.com/610576.

[Finnur, 2016-05-11 11:03:50]

Description was changed from

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753

Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753

Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}
==========

[Finnur, 2016-05-11 11:04:00]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-05-11 11:04:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1947493002/#ps200001
(title: "Address issue with GN")

[commit-bot: I haz the power, 2016-05-11 11:04:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947493002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947493002/200001

[commit-bot: I haz the power, 2016-05-11 12:01:57]

Description was changed from

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753

Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753

Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}
==========

[commit-bot: I haz the power, 2016-05-11 12:01:58]

Committed patchset #7 (id:200001)

[commit-bot: I haz the power, 2016-05-11 12:03:06]

Description was changed from

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753

Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}
==========

to

==========
Site Settings Android: A few polish items.

From issue 601918:
- Change "+ Add site" blue action link to be "+ Add site exception"
- Change dialog text to be: "Allow [JavaScript/the permission in question etc.]
for a specific site."

From issue 467788:
- Update the individual site settings page toggles with verbs that match the
permissions bubbles

From issue 604753 (partial fix):
- Improve alignment of Site Settings list a bit (move icon a bit to the right).
- Color the Site List heading blue.

Also add an updated image for Protected Content (slightly larger) and the Media
icon, which is for
the container menu that will house Protected Content and Autoplay.

BUG=601918, 467788, 604753

Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881
Cr-Commit-Position: refs/heads/master@{#392363}

Committed: https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b
Cr-Commit-Position: refs/heads/master@{#392899}
==========

[commit-bot: I haz the power, 2016-05-11 12:03:08]

Patchset 7 (id:??) landed as
https://crrev.com/91faabbb0fd92d636378508b4aa644b11bc4877b
Cr-Commit-Position: refs/heads/master@{#392899}