chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java - Issue 1947493002: Site Settings Android: A few polish items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

Issue 1947493002: Site Settings Android: A few polish items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue with GN Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/xml/site_settings_preferences.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

index e550c96e402f5fa8e399d45ed3fd31604a27d15e..f709b6972fc133f8764cc9a1df032419ca494775 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

@@ -60,6 +60,14 @@ public class ExpandablePreferenceGroup extends PreferenceGroup {

Spannable.SPAN_EXCLUSIVE_EXCLUSIVE);

}

+ // Color the first part of the title blue.

+ ForegroundColorSpan blueSpan = new ForegroundColorSpan(

+ ApiCompatibilityUtils.getColor(getContext().getResources(),

+ R.color.pref_accent_color));

+ spannable.setSpan(blueSpan, 0, spannable.length() - prefCount.length(),

+ Spannable.SPAN_EXCLUSIVE_EXCLUSIVE);

+ // Gray out the total count of items.

int gray = ApiCompatibilityUtils.getColor(getContext().getResources(),

R.color.expandable_group_dark_gray);

spannable.setSpan(new ForegroundColorSpan(gray),