Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1947123003: Fixes a crash which occurs when a concealed selection handle in a textfield is exposed. (Closed)

Created:
4 years, 7 months ago by mfomitchev
Modified:
4 years, 7 months ago
Reviewers:
mohsen
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@touch_devices_crash
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes a crash which occurs when a concealed selection handle in a textfield is exposed. The crash happened because the type of the SelectionBound within the handle wasn't getting initialized properly if the handle was invisible. The CL ensures that the correct SelectionBound type is maintained even for handles which are invisible. BUG=608687 Committed: https://crrev.com/d5cb3202cbde9e8d60632bfbcbb3ce1582ea36d3 Cr-Commit-Position: refs/heads/master@{#393885}

Patch Set 1 #

Patch Set 2 : Fixing the unit test on Windows - start the selection at 0, so that the drag doesn't overshoot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -29 lines) Patch
M ui/views/touchui/touch_selection_controller_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 7 chunks +23 lines, -6 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 4 chunks +54 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mfomitchev
PTAL
4 years, 7 months ago (2016-05-04 21:13:47 UTC) #2
mohsen
lgtm
4 years, 7 months ago (2016-05-05 18:09:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947123003/1
4 years, 7 months ago (2016-05-05 18:24:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/209069)
4 years, 7 months ago (2016-05-05 20:20:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947123003/20001
4 years, 7 months ago (2016-05-16 16:43:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-16 18:53:22 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:55:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5cb3202cbde9e8d60632bfbcbb3ce1582ea36d3
Cr-Commit-Position: refs/heads/master@{#393885}

Powered by Google App Engine
This is Rietveld 408576698