Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: ui/views/touchui/touch_selection_controller_impl.h

Issue 1947123003: Fixes a crash which occurs when a concealed selection handle in a textfield is exposed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@touch_devices_crash
Patch Set: Fixing the unit test on Windows - start the selection at 0, so that the drag doesn't overshoot. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/views/touchui/touch_selection_controller_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_UI_VIEWS_TOUCHUI_TOUCH_SELECTION_CONTROLLER_IMPL_H_ 5 #ifndef UI_UI_VIEWS_TOUCHUI_TOUCH_SELECTION_CONTROLLER_IMPL_H_
6 #define UI_UI_VIEWS_TOUCHUI_TOUCH_SELECTION_CONTROLLER_IMPL_H_ 6 #define UI_UI_VIEWS_TOUCHUI_TOUCH_SELECTION_CONTROLLER_IMPL_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/timer/timer.h" 9 #include "base/timer/timer.h"
10 #include "ui/aura/window_observer.h" 10 #include "ui/aura/window_observer.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 103
104 // Convenience method for hiding quick menu. 104 // Convenience method for hiding quick menu.
105 void HideQuickMenu(); 105 void HideQuickMenu();
106 106
107 // Convenience method to calculate anchor rect for quick menu, in screen 107 // Convenience method to calculate anchor rect for quick menu, in screen
108 // coordinates. 108 // coordinates.
109 gfx::Rect GetQuickMenuAnchorRect() const; 109 gfx::Rect GetQuickMenuAnchorRect() const;
110 110
111 // Convenience methods for testing. 111 // Convenience methods for testing.
112 gfx::NativeView GetCursorHandleNativeView(); 112 gfx::NativeView GetCursorHandleNativeView();
113 ui::SelectionBound::Type GetSelectionHandle1Type();
113 gfx::Rect GetSelectionHandle1Bounds(); 114 gfx::Rect GetSelectionHandle1Bounds();
114 gfx::Rect GetSelectionHandle2Bounds(); 115 gfx::Rect GetSelectionHandle2Bounds();
115 gfx::Rect GetCursorHandleBounds(); 116 gfx::Rect GetCursorHandleBounds();
116 bool IsSelectionHandle1Visible(); 117 bool IsSelectionHandle1Visible();
117 bool IsSelectionHandle2Visible(); 118 bool IsSelectionHandle2Visible();
118 bool IsCursorHandleVisible(); 119 bool IsCursorHandleVisible();
119 gfx::Rect GetExpectedHandleBounds(const ui::SelectionBound& bound); 120 gfx::Rect GetExpectedHandleBounds(const ui::SelectionBound& bound);
120 views::WidgetDelegateView* GetHandle1View(); 121 views::WidgetDelegateView* GetHandle1View();
121 views::WidgetDelegateView* GetHandle2View(); 122 views::WidgetDelegateView* GetHandle2View();
122 123
(...skipping 24 matching lines...) Expand all
147 // Selection bounds, clipped to client view's boundaries. 148 // Selection bounds, clipped to client view's boundaries.
148 ui::SelectionBound selection_bound_1_clipped_; 149 ui::SelectionBound selection_bound_1_clipped_;
149 ui::SelectionBound selection_bound_2_clipped_; 150 ui::SelectionBound selection_bound_2_clipped_;
150 151
151 DISALLOW_COPY_AND_ASSIGN(TouchSelectionControllerImpl); 152 DISALLOW_COPY_AND_ASSIGN(TouchSelectionControllerImpl);
152 }; 153 };
153 154
154 } // namespace views 155 } // namespace views
155 156
156 #endif // UI_UI_VIEWS_TOUCHUI_TOUCH_SELECTION_CONTROLLER_IMPL_H_ 157 #endif // UI_UI_VIEWS_TOUCHUI_TOUCH_SELECTION_CONTROLLER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | ui/views/touchui/touch_selection_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698