ui/views/touchui/touch_selection_controller_impl.h - Issue 1947123003: Fixes a crash which occurs when a concealed selection handle in a textfield is exposed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/touchui/touch_selection_controller_impl.h

Issue 1947123003: Fixes a crash which occurs when a concealed selection handle in a textfield is exposed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@touch_devices_crash

Patch Set: Fixing the unit test on Windows - start the selection at 0, so that the drag doesn't overshoot. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/touchui/touch_selection_controller_impl.h

diff --git a/ui/views/touchui/touch_selection_controller_impl.h b/ui/views/touchui/touch_selection_controller_impl.h

index 295c85ccd73a33cc51185180a5c1f4f917922075..1580bfb1f5c6960c3c5490604ccfcba7b8432a80 100644

--- a/ui/views/touchui/touch_selection_controller_impl.h

+++ b/ui/views/touchui/touch_selection_controller_impl.h

@@ -110,6 +110,7 @@ class VIEWS_EXPORT TouchSelectionControllerImpl

// Convenience methods for testing.

gfx::NativeView GetCursorHandleNativeView();

+ ui::SelectionBound::Type GetSelectionHandle1Type();

gfx::Rect GetSelectionHandle1Bounds();

gfx::Rect GetSelectionHandle2Bounds();

gfx::Rect GetCursorHandleBounds();

« no previous file with comments | « no previous file | ui/views/touchui/touch_selection_controller_impl.cc » ('j') | no next file with comments »