Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 1946873005: Move LoadLibraryAndPrintError helpers to common gl_implementation.h/.cc (Closed)

Created:
4 years, 7 months ago by Julien Isorce Samsung
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LoadLibraryAndPrintError helpers to common gl_implementation.h/.cc These functions are implemented in gl_implementation_osmesa.cc but used in gl_implementation_x11.cc and gl_implementation_android.cc. If LoadLibraryAndPrintError fails the log message starts with gl_implementation_osmesa.cc which is confusing. BUG=264818 R=kbr@chromium.org Committed: https://crrev.com/7aa906d2c7cb045897562dffa70873c60a2829c9 Cr-Commit-Position: refs/heads/master@{#392158}

Patch Set 1 #

Patch Set 2 : Rebase and use base::FilePath::CharType to fix build failure on win os #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M ui/gl/gl_implementation.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_osmesa.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation_osmesa.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946873005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946873005/1
4 years, 7 months ago (2016-05-05 20:09:07 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/143755)
4 years, 7 months ago (2016-05-05 21:02:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946873005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946873005/20001
4 years, 7 months ago (2016-05-05 21:48:12 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 23:42:50 UTC) #8
Julien Isorce Samsung
On 2016/05/05 23:42:50, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-05-06 14:45:34 UTC) #9
Ken Russell (switch to Gerrit)
lgtm
4 years, 7 months ago (2016-05-06 20:48:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946873005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946873005/20001
4 years, 7 months ago (2016-05-06 21:21:41 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 21:25:23 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 21:26:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7aa906d2c7cb045897562dffa70873c60a2829c9
Cr-Commit-Position: refs/heads/master@{#392158}

Powered by Google App Engine
This is Rietveld 408576698