Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: ui/gl/gl_implementation.h

Issue 1946873005: Move LoadLibraryAndPrintError helpers to common gl_implementation.h/.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and use base::FilePath::CharType to fix build failure on win os Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/gl/gl_implementation.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GL_GL_IMPLEMENTATION_H_ 5 #ifndef UI_GL_GL_IMPLEMENTATION_H_
6 #define UI_GL_GL_IMPLEMENTATION_H_ 6 #define UI_GL_GL_IMPLEMENTATION_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/files/file_path.h"
11 #include "base/native_library.h" 12 #include "base/native_library.h"
12 #include "build/build_config.h" 13 #include "build/build_config.h"
13 #include "ui/gl/gl_export.h" 14 #include "ui/gl/gl_export.h"
14 #include "ui/gl/gl_switches.h" 15 #include "ui/gl/gl_switches.h"
15 16
16 namespace gfx { 17 namespace gfx {
17 18
18 class GLContext; 19 class GLContext;
19 20
20 // The GL implementation currently in use. 21 // The GL implementation currently in use.
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 // intended for users of the bindings, not the implementation of the 129 // intended for users of the bindings, not the implementation of the
129 // bindings themselves. This is a relatively expensive call, so 130 // bindings themselves. This is a relatively expensive call, so
130 // callers should cache the result. 131 // callers should cache the result.
131 GL_EXPORT std::string GetGLExtensionsFromCurrentContext(); 132 GL_EXPORT std::string GetGLExtensionsFromCurrentContext();
132 133
133 // Helper for the GL bindings implementation to understand whether 134 // Helper for the GL bindings implementation to understand whether
134 // glGetString(GL_EXTENSIONS) or glGetStringi(GL_EXTENSIONS, i) will 135 // glGetString(GL_EXTENSIONS) or glGetStringi(GL_EXTENSIONS, i) will
135 // be used in the function above. 136 // be used in the function above.
136 GL_EXPORT bool WillUseGLGetStringForExtensions(); 137 GL_EXPORT bool WillUseGLGetStringForExtensions();
137 138
139 // Helpers to load a library and log error on failure.
140 base::NativeLibrary LoadLibraryAndPrintError(
141 const base::FilePath::CharType* filename);
142 base::NativeLibrary LoadLibraryAndPrintError(const base::FilePath& filename);
143
138 } // namespace gfx 144 } // namespace gfx
139 145
140 #endif // UI_GL_GL_IMPLEMENTATION_H_ 146 #endif // UI_GL_GL_IMPLEMENTATION_H_
OLDNEW
« no previous file with comments | « no previous file | ui/gl/gl_implementation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698