Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: ui/gl/gl_implementation_osmesa.cc

Issue 1946873005: Move LoadLibraryAndPrintError helpers to common gl_implementation.h/.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and use base::FilePath::CharType to fix build failure on win os Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_implementation_osmesa.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_implementation_osmesa.cc
diff --git a/ui/gl/gl_implementation_osmesa.cc b/ui/gl/gl_implementation_osmesa.cc
index 90de6909b91285bf5eff751ad589d6d1ef87e4e3..30ba3f8fd537d08f9cc342a1fc58c98845b02351 100644
--- a/ui/gl/gl_implementation_osmesa.cc
+++ b/ui/gl/gl_implementation_osmesa.cc
@@ -15,21 +15,6 @@
namespace gfx {
-base::NativeLibrary LoadLibraryAndPrintError(const base::FilePath& filename) {
- base::NativeLibraryLoadError error;
- base::NativeLibrary library = base::LoadNativeLibrary(filename, &error);
- if (!library) {
- LOG(ERROR) << "Failed to load " << filename.MaybeAsASCII() << ": "
- << error.ToString();
- return NULL;
- }
- return library;
-}
-
-base::NativeLibrary LoadLibraryAndPrintError(const char* filename) {
- return LoadLibraryAndPrintError(base::FilePath(filename));
-}
-
bool InitializeStaticGLBindingsOSMesaGL() {
base::FilePath module_path;
if (!PathService::Get(base::DIR_MODULE, &module_path)) {
« no previous file with comments | « ui/gl/gl_implementation_osmesa.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698