Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1946693002: Revert of Relax a couple checks to allow certain non-standard PDF files. (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Relax a couple checks to allow certain non-standard PDF files. (patchset #1 id:1 of https://codereview.chromium.org/1926823002/ ) Reason for revert: Speculatively revert due to high volume of crashes on Chromium. Original issue's description: > Relax a couple checks to allow certain non-standard PDF files. > > Some non-standard PDF files misuse the size of cross reference table, > and reuse some object number which the old one is still in use. PDFium > can relax the reusing of xref objects only since it is not referred in > the pdf document. When the size of cross reference table is larger > than defined, PDFium will try to continue other than abort. > > BUG=chromium:596947 > > Committed: https://pdfium.googlesource.com/pdfium/+/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734 TBR=thestig@chromium.org,dsinclair@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:596947 Committed: https://pdfium.googlesource.com/pdfium/+/5fc4f31285c3a88fc157fd2d9b9cf2eb5c7cabed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -38 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp View 2 chunks +4 lines, -16 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
D testing/resources/bug_596947.pdf View Binary file 0 comments Download

Messages

Total messages: 5 (1 generated)
Wei Li
Created Revert of Relax a couple checks to allow certain non-standard PDF files.
4 years, 7 months ago (2016-05-03 18:32:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946693002/1
4 years, 7 months ago (2016-05-03 18:33:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/5fc4f31285c3a88fc157fd2d9b9cf2eb5c7cabed
4 years, 7 months ago (2016-05-03 18:46:21 UTC) #4
Wei Li
4 years, 7 months ago (2016-05-04 16:36:04 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1947983002/ by weili@chromium.org.

The reason for reverting is: The culprit was found and confirmed, not this one.
.

Powered by Google App Engine
This is Rietveld 408576698