Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1926823002: Relax a couple checks to allow certain non-standard PDF files. (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Relax a couple checks to allow certain non-standard PDF files. Some non-standard PDF files misuse the size of cross reference table, and reuse some object number which the old one is still in use. PDFium can relax the reusing of xref objects only since it is not referred in the pdf document. When the size of cross reference table is larger than defined, PDFium will try to continue other than abort. BUG=chromium:596947 Committed: https://pdfium.googlesource.com/pdfium/+/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp View 2 chunks +16 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
A testing/resources/bug_596947.pdf View Binary file 0 comments Download

Messages

Total messages: 8 (3 generated)
Wei Li
for review, thanks
4 years, 7 months ago (2016-04-27 17:57:02 UTC) #2
dsinclair
lgtm
4 years, 7 months ago (2016-04-27 18:21:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926823002/1
4 years, 7 months ago (2016-04-29 17:11:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734
4 years, 7 months ago (2016-04-29 17:24:05 UTC) #7
Wei Li
4 years, 7 months ago (2016-05-03 18:32:48 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1946693002/ by weili@chromium.org.

The reason for reverting is: Speculatively revert due to high volume of crashes
on Chromium..

Powered by Google App Engine
This is Rietveld 408576698