Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1946543002: Revert "Straighten out zoom and border-image" (Closed)

Created:
4 years, 7 months ago by davve
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert "Straighten out zoom and border-image" This patch reverts https://codereview.chromium.org/1819083004 patchset Fixing SVG zoom in border-image unfortunatly broke gradients instead. There is a difference in how scale it applied for zooming. For SVG a source rect (unzoomed) <-> destination rect (zoomed) scale factor is computed and used for scaling. For gradients, the source and destination rect are always the same (both zoomed). The individual gradients stops are zoomed instead. BUG=607414, 596075, 561519 Review-Url: https://codereview.chromium.org/1934953002 Cr-Commit-Position: refs/heads/master@{#390920} (cherry picked from commit 6529aa5b970ab274de1ff4c0475f223930babff7) Committed: https://chromium.googlesource.com/chromium/src/+/96c436224c8f8c681c6b441f130c3839784d746c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -57 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/border-image-zoomed.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/border-image-zoomed-expected.html View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
davve
4 years, 7 months ago (2016-05-03 13:07:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96c436224c8f8c681c6b441f130c3839784d746c.

Powered by Google App Engine
This is Rietveld 408576698