Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1934953002: Revert "Straighten out zoom and border-image" (Closed)

Created:
4 years, 7 months ago by davve
Modified:
4 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Straighten out zoom and border-image" This patch reverts https://codereview.chromium.org/1819083004 patchset #3. Fixing SVG zoom in border-image unfortunatly broke gradients instead. There is a difference in how scale it applied for zooming. For SVG a source rect (unzoomed) <-> destination rect (zoomed) scale factor is computed and used for scaling. For gradients, the source and destination rect are always the same (both zoomed). The individual gradients stops are zoomed instead. BUG=607414, 596075, 561519 Committed: https://crrev.com/6529aa5b970ab274de1ff4c0475f223930babff7 Cr-Commit-Position: refs/heads/master@{#390920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -57 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/border-image-zoomed.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/border-image-zoomed-expected.html View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934953002/1
4 years, 7 months ago (2016-05-02 10:37:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 11:38:04 UTC) #4
davve
A test for what broke is upcoming. Since that's not important for an potential merge, ...
4 years, 7 months ago (2016-05-02 11:43:37 UTC) #8
fs
lgtm
4 years, 7 months ago (2016-05-02 11:52:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934953002/1
4 years, 7 months ago (2016-05-02 11:54:22 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 11:58:01 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 11:59:48 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6529aa5b970ab274de1ff4c0475f223930babff7
Cr-Commit-Position: refs/heads/master@{#390920}

Powered by Google App Engine
This is Rietveld 408576698