Revert "Straighten out zoom and border-image"

Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops are zoomed instead.

BUG=607414, 596075, 561519
Committed: https://crrev.com/6529aa5b970ab274de1ff4c0475f223930babff7
Cr-Commit-Position: refs/heads/master@{#390920}

[davve, 2016-05-02 10:36:31]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 10:37:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934953002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934953002/1

[commit-bot: I haz the power, 2016-05-02 11:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 11:38:04]

Dry run: This issue passed the CQ dry run.

[davve, 2016-05-02 11:40:06]

Description was changed from

==========
Revert "Straighten out zoom and border-image"

This reverts commit 5375a43082553e259159d42ef83f727ed9fe5463.

The border-image-slice property determines how the image is sliced
into the nine piece pattern. Since border-image-slice are not lengths,
they are not automatically zoomed in computed style. Thus the zoom
factor hasn't been applied to the image size either. For border-image
the image size has no impact on the destination area anyway, so this
part is fine.

However, the default object size is in zoomed coordinates and unless
the default object size is unzoomed, there will be a mix of zoomed and
unzoomed coordinates when calculating the final image size for image
sizes that depend on the default object size, e.g. SVG with no
intrinsic size.

For this reason, unzoom the default object size before using it to
compute the image size.

Since the zoom passed to StyleImage::image() should represent the zoom
applied to the image size, it follows from this that the zoom should
be one.

BUG=596075, 561519

Review URL: https://codereview.chromium.org/1819083004

Cr-Commit-Position: refs/heads/master@{#382842}
==========

to

==========
Revert "Straighten out zoom and border-image"

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed ) the
individual gradients stops zoomed instead.

BUG=607414, 596075, 561519
==========

[davve, 2016-05-02 11:41:40]

Description was changed from

==========
Revert "Straighten out zoom and border-image"

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed ) the
individual gradients stops zoomed instead.

BUG=607414, 596075, 561519
==========

to

==========
Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed ) the
individual gradients stops zoomed instead.

BUG=607414, 596075, 561519
==========

[davve, 2016-05-02 11:43:36]

davve@opera.com changed reviewers:
+ fs@opera.com

[davve, 2016-05-02 11:43:37]

A test for what broke is upcoming. Since that's not important for an potential
merge, I'll leave it out of this patch.

[fs, 2016-05-02 11:52:06]

lgtm

[davve, 2016-05-02 11:53:27]

Description was changed from

==========
Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed ) the
individual gradients stops zoomed instead.

BUG=607414, 596075, 561519
==========

to

==========
Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops zoomed instead.

BUG=607414, 596075, 561519
==========

[davve, 2016-05-02 11:53:46]

Description was changed from

==========
Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops zoomed instead.

BUG=607414, 596075, 561519
==========

to

==========
Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops are zoomed instead.

BUG=607414, 596075, 561519
==========

[davve, 2016-05-02 11:54:06]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2016-05-02 11:54:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1934953002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1934953002/1

[commit-bot: I haz the power, 2016-05-02 11:58:00]

Description was changed from

==========
Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops are zoomed instead.

BUG=607414, 596075, 561519
==========

to

==========
Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops are zoomed instead.

BUG=607414, 596075, 561519
==========

[commit-bot: I haz the power, 2016-05-02 11:58:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-02 11:59:47]

Description was changed from

==========
Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops are zoomed instead.

BUG=607414, 596075, 561519
==========

to

==========
Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops are zoomed instead.

BUG=607414, 596075, 561519

Committed: https://crrev.com/6529aa5b970ab274de1ff4c0475f223930babff7
Cr-Commit-Position: refs/heads/master@{#390920}
==========

[commit-bot: I haz the power, 2016-05-02 11:59:48]

Patchset 1 (id:??) landed as
https://crrev.com/6529aa5b970ab274de1ff4c0475f223930babff7
Cr-Commit-Position: refs/heads/master@{#390920}