Straighten out zoom and border-image

Straighten out zoom and border-image

The border-image-slice property determines how the image is sliced
into the nine piece pattern. Since border-image-slice are not lengths,
they are not automatically zoomed in computed style. Thus the zoom
factor hasn't been applied to the image size either. For border-image
the image size has no impact on the destination area anyway, so this
part is fine.

However, the default object size is in zoomed coordinates and unless
the default object size is unzoomed, there will be a mix of zoomed and
unzoomed coordinates when calculating the final image size for image
sizes that depend on the default object size, e.g. SVG with no
intrinsic size.

For this reason, unzoom the default object size before using it to
compute the image size.

Since the zoom passed to StyleImage::image() should represent the zoom
applied to the image size, it follows from this that the zoom should
be one.

BUG=596075, 561519
Committed: https://crrev.com/5375a43082553e259159d42ef83f727ed9fe5463
Cr-Commit-Position: refs/heads/master@{#382842}

[davve, 2016-03-22 12:39:01]

Description was changed from

==========
p.se# Enter a description of the change.
Straighten out zoom and border-image

The border-image-slice property determines how the image is sliced
into the nine piece pattern. Since border-image-slice are not lengths,
they are not automatically zoomed in computed style. Thus the zoom
factor hasn't been applied to the image size either. For border-image
the image size has no impact on the destination area anyway, so this
part is fine.

However, the default object size is in zoomed coordinates and unless
the default object size is unzoomed, there will be a mix of zoomed and
unzoomed coordinates when calculating the final image size for image
sizes that depend on the default object size, e.g. SVG with no
intrinsic size.

For this reason, unzoom the default object size before using it to
compute the image size.

Since the zoom passed to StyleImage::image() should represent the zoom
applied to the image size, it follows from this that the zoom should
be one.

BUG=596075, 561519
==========

to

==========
Straighten out zoom and border-image

The border-image-slice property determines how the image is sliced
into the nine piece pattern. Since border-image-slice are not lengths,
they are not automatically zoomed in computed style. Thus the zoom
factor hasn't been applied to the image size either. For border-image
the image size has no impact on the destination area anyway, so this
part is fine.

However, the default object size is in zoomed coordinates and unless
the default object size is unzoomed, there will be a mix of zoomed and
unzoomed coordinates when calculating the final image size for image
sizes that depend on the default object size, e.g. SVG with no
intrinsic size.

For this reason, unzoom the default object size before using it to
compute the image size.

Since the zoom passed to StyleImage::image() should represent the zoom
applied to the image size, it follows from this that the zoom should
be one.

BUG=596075, 561519
==========

[davve, 2016-03-22 13:52:52]

davve@opera.com changed reviewers:
+ fs@opera.com

[davve, 2016-03-22 13:52:53]

PTAL

[fs, 2016-03-22 14:07:23]

lgtm

https://codereview.chromium.org/1819083004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp (right):

https://codereview.chromium.org/1819083004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp:60: RefPtr<Image>
image = styleImage->image(m_layoutObject, imageSize, 1);
Maybe add a comment (or two) about why the zoom/scale factors are chosen this
way (i.e a boiled down version of the commit message or so.)

[davve, 2016-03-22 14:29:00]

https://codereview.chromium.org/1819083004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp (right):

https://codereview.chromium.org/1819083004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp:60: RefPtr<Image>
image = styleImage->image(m_layoutObject, imageSize, 1);
On 2016/03/22 14:07:23, fs wrote:
> Maybe add a comment (or two) about why the zoom/scale factors are chosen this
> way (i.e a boiled down version of the commit message or so.)

I added two lines to the follow-up documentation patch I was scribbling at
anyway.

https://codereview.chromium.org/1824003002

Would that do?

[davve, 2016-03-22 14:31:40]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 14:31:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819083004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819083004/40001

[fs, 2016-03-22 14:45:14]

On 2016/03/22 at 14:29:00, davve wrote:
>
https://codereview.chromium.org/1819083004/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp (right):
> 
>
https://codereview.chromium.org/1819083004/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp:60:
RefPtr<Image> image = styleImage->image(m_layoutObject, imageSize, 1);
> On 2016/03/22 14:07:23, fs wrote:
> > Maybe add a comment (or two) about why the zoom/scale factors are chosen
this
> > way (i.e a boiled down version of the commit message or so.)
> 
> I added two lines to the follow-up documentation patch I was scribbling at
anyway.
> 
> https://codereview.chromium.org/1824003002
> 
> Would that do?

Yepp, seems fine to me.

[davve, 2016-03-22 14:54:20]

The CQ bit was checked by davve@opera.com

[davve, 2016-03-22 14:54:22]

The CQ bit was unchecked by davve@opera.com

[davve, 2016-03-23 12:25:18]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2016-03-23 12:25:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819083004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819083004/40001

[commit-bot: I haz the power, 2016-03-23 13:26:54]

Description was changed from

==========
Straighten out zoom and border-image

The border-image-slice property determines how the image is sliced
into the nine piece pattern. Since border-image-slice are not lengths,
they are not automatically zoomed in computed style. Thus the zoom
factor hasn't been applied to the image size either. For border-image
the image size has no impact on the destination area anyway, so this
part is fine.

However, the default object size is in zoomed coordinates and unless
the default object size is unzoomed, there will be a mix of zoomed and
unzoomed coordinates when calculating the final image size for image
sizes that depend on the default object size, e.g. SVG with no
intrinsic size.

For this reason, unzoom the default object size before using it to
compute the image size.

Since the zoom passed to StyleImage::image() should represent the zoom
applied to the image size, it follows from this that the zoom should
be one.

BUG=596075, 561519
==========

to

==========
Straighten out zoom and border-image

The border-image-slice property determines how the image is sliced
into the nine piece pattern. Since border-image-slice are not lengths,
they are not automatically zoomed in computed style. Thus the zoom
factor hasn't been applied to the image size either. For border-image
the image size has no impact on the destination area anyway, so this
part is fine.

However, the default object size is in zoomed coordinates and unless
the default object size is unzoomed, there will be a mix of zoomed and
unzoomed coordinates when calculating the final image size for image
sizes that depend on the default object size, e.g. SVG with no
intrinsic size.

For this reason, unzoom the default object size before using it to
compute the image size.

Since the zoom passed to StyleImage::image() should represent the zoom
applied to the image size, it follows from this that the zoom should
be one.

BUG=596075, 561519
==========

[commit-bot: I haz the power, 2016-03-23 13:26:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-23 13:28:24]

Description was changed from

==========
Straighten out zoom and border-image

The border-image-slice property determines how the image is sliced
into the nine piece pattern. Since border-image-slice are not lengths,
they are not automatically zoomed in computed style. Thus the zoom
factor hasn't been applied to the image size either. For border-image
the image size has no impact on the destination area anyway, so this
part is fine.

However, the default object size is in zoomed coordinates and unless
the default object size is unzoomed, there will be a mix of zoomed and
unzoomed coordinates when calculating the final image size for image
sizes that depend on the default object size, e.g. SVG with no
intrinsic size.

For this reason, unzoom the default object size before using it to
compute the image size.

Since the zoom passed to StyleImage::image() should represent the zoom
applied to the image size, it follows from this that the zoom should
be one.

BUG=596075, 561519
==========

to

==========
Straighten out zoom and border-image

The border-image-slice property determines how the image is sliced
into the nine piece pattern. Since border-image-slice are not lengths,
they are not automatically zoomed in computed style. Thus the zoom
factor hasn't been applied to the image size either. For border-image
the image size has no impact on the destination area anyway, so this
part is fine.

However, the default object size is in zoomed coordinates and unless
the default object size is unzoomed, there will be a mix of zoomed and
unzoomed coordinates when calculating the final image size for image
sizes that depend on the default object size, e.g. SVG with no
intrinsic size.

For this reason, unzoom the default object size before using it to
compute the image size.

Since the zoom passed to StyleImage::image() should represent the zoom
applied to the image size, it follows from this that the zoom should
be one.

BUG=596075, 561519

Committed: https://crrev.com/5375a43082553e259159d42ef83f727ed9fe5463
Cr-Commit-Position: refs/heads/master@{#382842}
==========

[commit-bot: I haz the power, 2016-03-23 13:28:25]

Patchset 3 (id:??) landed as
https://crrev.com/5375a43082553e259159d42ef83f727ed9fe5463
Cr-Commit-Position: refs/heads/master@{#382842}