Chromium Code Reviews| Index: appengine/findit/crash/fracas_crash_pipeline.py |
| diff --git a/appengine/findit/crash/fracas_crash_pipeline.py b/appengine/findit/crash/fracas_crash_pipeline.py |
| index 5c06280cd1104fef7367dabb703ca61222a90f03..6292008dac31f1829d775bc691d1cb5bdaa3560b 100644 |
| --- a/appengine/findit/crash/fracas_crash_pipeline.py |
| +++ b/appengine/findit/crash/fracas_crash_pipeline.py |
| @@ -61,7 +61,7 @@ class FracasAnalysisPipeline(FracasBasePipeline): |
| # Run the analysis. |
| result, tags = fracas.FindCulpritForChromeCrash( |
| channel, platform, signature, analysis.stack_trace, |
| - analysis.crashed_version, analysis.versions_to_cpm) |
| + analysis.crashed_version, analysis.versions_to_historical) |
|
Martin Barbella
2016/05/03 18:43:09
Left a comment on Mimee's CL as well, but this is
Sharu Jiang
2016/05/03 23:48:03
Changed to historic_metadata :)
|
| # Update analysis status and save the analysis result. |
| analysis.completed_time = datetime.datetime.utcnow() |
| @@ -108,7 +108,8 @@ class FracasCrashWrapperPipeline(BasePipeline): |
| @ndb.transactional |
| def _NeedsNewAnalysis( |
| - channel, platform, signature, stack_trace, chrome_version, versions_to_cpm): |
| + channel, platform, signature, stack_trace, |
| + chrome_version, versions_to_historical): |
| analysis = FracasCrashAnalysis.Get(channel, platform, signature) |
| if analysis and not analysis.failed: |
| # A new analysis is not needed if last one didn't complete or succeeded. |
| @@ -123,7 +124,7 @@ def _NeedsNewAnalysis( |
| analysis.Reset() |
| analysis.crashed_version = chrome_version |
| analysis.stack_trace = stack_trace |
| - analysis.versions_to_cpm = versions_to_cpm |
| + analysis.versions_to_historical = versions_to_historical |
| analysis.status = analysis_status.PENDING |
| analysis.requested_time = datetime.datetime.utcnow() |
| analysis.put() |
| @@ -131,7 +132,8 @@ def _NeedsNewAnalysis( |
| def ScheduleNewAnalysisForCrash( |
| - channel, platform, signature, stack_trace, chrome_version, versions_to_cpm, |
| + channel, platform, signature, stack_trace, chrome_version, |
| + versions_to_historical, |
| queue_name=constants.DEFAULT_QUEUE): |
| """Schedules an analysis.""" |
| crash_config = CrashConfig.Get() |
| @@ -141,7 +143,7 @@ def ScheduleNewAnalysisForCrash( |
| return False |
| if _NeedsNewAnalysis(channel, platform, signature, stack_trace, |
| - chrome_version, versions_to_cpm): |
| + chrome_version, versions_to_historical): |
| analysis_pipeline = FracasCrashWrapperPipeline(channel, platform, signature) |
| analysis_pipeline.target = appengine_util.GetTargetNameForModule( |
| constants.CRASH_BACKEND_FRACAS) |