Chromium Code Reviews| Index: appengine/findit/handlers/crash/fracas_crash.py |
| diff --git a/appengine/findit/handlers/crash/fracas_crash.py b/appengine/findit/handlers/crash/fracas_crash.py |
| index 8926f7680272cd1f2fcb890299c184b5d7f2ed06..c1ca257c0872cd73806a3d8b33f8bc9a96bc246c 100644 |
| --- a/appengine/findit/handlers/crash/fracas_crash.py |
| +++ b/appengine/findit/handlers/crash/fracas_crash.py |
| @@ -20,15 +20,35 @@ class FracasCrash(BaseHandler): |
| The crash data should be in the following json format: |
| { |
| - 'channel': 'canary', |
| - 'platform': 'win', |
| - 'signature': 'namesapce1:namespace2:class_name:func_name', |
| - 'stack_trace': 'frame1\nframe2\nframe3', |
| - 'chrome_version': '50.0.2500.0', |
| - 'versions_to_cpm': { |
| - '50.0.2500.0': 1.2, |
| - '50.0.2499.0': 1.0, |
| + "customized_data": { |
| + "channel": "beta", |
| + "versions_to_historical": [ |
| + { |
| + "chrome_version": "51.0.2693.2", |
| + "cpm": 0.0610491148 |
| + }, |
| + { |
| + "chrome_version": "51.0.2704.10", |
| + "cpm": 0.0490386976 |
| + }, |
| + { |
| + "chrome_version": "52.0.2718.2", |
| + "cpm": 0.0040353297 |
| + } |
| + ] |
| }, |
| + "chrome_version": "51.0.2704.28", |
| + "signature": "blink::FramePainter::paintContents", |
| + "client_id": "fracas", |
| + "platform": "android", |
| + "crash_identifiers": { |
| + "chrome_version": "51.0.2704.28", |
| + "signature": "blink::FramePainter::paintContents", |
| + "channel": "beta", |
| + "platform": "android", |
| + "process_type": null |
| + }, |
| + "stack_trace": "CRASHED [SIGILL @ 0x5320e570]\\n#0 0x5320e570..." |
| } |
| """ |
| try: |
| @@ -41,9 +61,10 @@ class FracasCrash(BaseHandler): |
| received_message['subscription']) |
| fracas_crash_pipeline.ScheduleNewAnalysisForCrash( |
|
stgao
2016/05/03 18:58:34
``crash_identifiers`` should be passed over, used
Sharu Jiang
2016/05/03 23:48:03
Done.
|
| - crash_data['channel'], crash_data['platform'], |
| + crash_data['customized_data']['channel'], crash_data['platform'], |
| crash_data['signature'], crash_data['stack_trace'], |
| - crash_data['chrome_version'], crash_data['versions_to_cpm'], |
| + crash_data['chrome_version'], |
| + crash_data['customized_data']['versions_to_historical'], |
| queue_name=constants.CRASH_ANALYSIS_FRACAS_QUEUE) |
| except (KeyError, ValueError): # pragma: no cover. |
| # TODO: save exception in datastore and create a page to show them. |