[Findit] Modify the handler for fracas input message.

appengine/findit/crash/fracas_crash_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import datetime
 import json
 import logging
 
 from google.appengine.ext import ndb
@@ skipping 43 matching lines @@
     # Update analysis status.
     analysis.pipeline_status_path = self.pipeline_status_path()
     analysis.status = analysis_status.RUNNING
     analysis.started_time = datetime.datetime.utcnow()
     analysis.findit_version = appengine_util.GetCurrentVersion()
     analysis.put()
 
     # Run the analysis.
     result, tags = fracas.FindCulpritForChromeCrash(
         channel, platform, signature, analysis.stack_trace,
-        analysis.crashed_version, analysis.versions_to_cpm)
+        analysis.crashed_version, analysis.versions_to_historical)

[Martin Barbella, 2016/05/03 18:43:09]

Left a comment on Mimee's CL as well, but this is a very confusing name.

[Sharu Jiang, 2016/05/03 23:48:03]

Changed to historic_metadata :)

 
     # Update analysis status and save the analysis result.
     analysis.completed_time = datetime.datetime.utcnow()
     analysis.result = result
     for tag_name, tag_value in tags.iteritems():
       # TODO(http://crbug.com/602702): make it possible to add arbitrary tags.
       if hasattr(analysis, tag_name):
         setattr(analysis, tag_name, tag_value)
     analysis.status = analysis_status.COMPLETED
     analysis.put()
@@ skipping 26 matching lines @@
 class FracasCrashWrapperPipeline(BasePipeline):
   # Arguments number differs from overridden method - pylint: disable=W0221
   def run(self, channel, platform, signature):
     run_analysis = yield FracasAnalysisPipeline(channel, platform, signature)
     with pipeline.After(run_analysis):
       yield PublishResultPipeline(channel, platform, signature)
 
 
 @ndb.transactional
 def _NeedsNewAnalysis(
-    channel, platform, signature, stack_trace, chrome_version, versions_to_cpm):
+    channel, platform, signature, stack_trace,
+    chrome_version, versions_to_historical):
   analysis = FracasCrashAnalysis.Get(channel, platform, signature)
   if analysis and not analysis.failed:
     # A new analysis is not needed if last one didn't complete or succeeded.
     # TODO(http://crbug.com/600535): re-analyze if stack trace or regression
     # range changed.
     return False
 
   if not analysis:
     # A new analysis is needed if there is no analysis yet.
     analysis = FracasCrashAnalysis.Create(channel, platform, signature)
 
   analysis.Reset()
   analysis.crashed_version = chrome_version
   analysis.stack_trace = stack_trace
-  analysis.versions_to_cpm = versions_to_cpm
+  analysis.versions_to_historical = versions_to_historical
   analysis.status = analysis_status.PENDING
   analysis.requested_time = datetime.datetime.utcnow()
   analysis.put()
   return True
 
 
 def ScheduleNewAnalysisForCrash(
-    channel, platform, signature, stack_trace, chrome_version, versions_to_cpm,
+    channel, platform, signature, stack_trace, chrome_version,
+    versions_to_historical,
     queue_name=constants.DEFAULT_QUEUE):
   """Schedules an analysis."""
   crash_config = CrashConfig.Get()
   if platform not in crash_config.fracas.get(
       'supported_platform_list_by_channel', {}).get(channel, []):
     # Bail out if either the channel or platform is not supported yet.
     return False
 
   if _NeedsNewAnalysis(channel, platform, signature, stack_trace,
-                       chrome_version, versions_to_cpm):
+                       chrome_version, versions_to_historical):
     analysis_pipeline = FracasCrashWrapperPipeline(channel, platform, signature)
     analysis_pipeline.target = appengine_util.GetTargetNameForModule(
         constants.CRASH_BACKEND_FRACAS)
     analysis_pipeline.start(queue_name=queue_name)
     logging.info('New analysis is scheduled for %s, %s, %s',
                  channel, platform, signature)
     return True
 
   return False