bluetooth: Separate requestDevice tests

bluetooth: Separate requestDevice tests

BUG=554240
Committed: https://crrev.com/b5e139fd003e69025f2422d4a2635ac3a74cb153
Cr-Commit-Position: refs/heads/master@{#393060}

[ortuno, 2016-05-06 19:30:01]

Description was changed from

==========
bluetooth: (WIP) Separate requestDevice tests

BUG=
==========

to

==========
bluetooth: Separate requestDevice tests

BUG=554240
==========

[ortuno, 2016-05-06 19:33:45]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2016-05-06 19:33:46]

jyasskin: PTAL. This is the last one!

[Jeffrey Yasskin, 2016-05-09 22:09:58]

That was big!

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-namePrefix.html:42:
}, 'A filter must restrict the devices in some way.');
This test name should be distinct from
https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
name.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-name.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-name.html:16:
'Device name longer than 29'));
s/29/248/

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-namePrefix.html:17:
}, 'A device name longer than 248 must reject.');
Keep this name distinct from
https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...:
s/name/name prefix/?

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-namePrefix.html:19:
}, 'A device name longer than 29 must reject.');
Same here, s/name/name prefix/

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/no-arguments.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/no-arguments.html:12:
}, 'Requires an argument.');
Probably "requestDevice() requires an argument."

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html:20:
}, 'Unicode string with utf8 representation between (29, 248] must throw ' +
"between (29, 248] bytes"?

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-namePrefix.html:20:
}, 'Unicode string with utf8 representation between (29, 248] must throw ' +
Distinguish this one from the 'name' variant too.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-name-in-adv-name.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-name-in-adv-name.html:18:
}, 'Unicode string with utf8 representation greater than 248 must throw ' +
"greater than 248 bytes", I think.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-name.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-name.html:7:
promise_test(() => {
This filename has a typo: lenght->length

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-name.html:9:
9, '\u2764'); // \u2764's UTF-8 representationis 3 bytes long.
s/representationis/representation is/

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-namePrefix.html:7:
promise_test(() => {
This filename also has a typo.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-namePrefix.html:9:
9, '\u2764'); // \u2764's UTF-8 representationis 3 bytes long.
sp: representationis

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/discovery-succeeds.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/discovery-succeeds.html:11:
.then(() => requestDeviceWithKeyDown({
Comment why you can't do this in parallel. (Because Chrome would always close
one in the process of handling the user gesture for the next one, right?)

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/processing-user-gesture.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/processing-user-gesture.html:8:
promise_test(() => {
This file is the same as
https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...;
you probably only need one.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/single-filter-two-services-fails.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/single-filter-two-services-fails.html:9:
// Both devices support the Generic Access service, but things need to
s/Generic Access/Heart Rate/

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:309:
services = (services === undefined) ? ['heart_rate'] : services;
Make this an if statement:

if (services === undefined) {
  services = ['heart_rate'];
}

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:311:
filters: [{ services: services}]
Nit: Be symmetric with the spaces inside {}s: probably include 1 space on both
sides.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:335: //
to clean up this state after each test. Once the move to Mojo is complete
If this is the last change to split up tests, remove this at the same time?

[ortuno, 2016-05-11 19:29:39]

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-namePrefix.html:42:
}, 'A filter must restrict the devices in some way.');
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> This test name should be distinct from
https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
name.

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-name.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-name.html:16:
'Device name longer than 29'));
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> s/29/248/

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-namePrefix.html:17:
}, 'A device name longer than 248 must reject.');
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> Keep this name distinct from
https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...:
s/name/name prefix/?

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-namePrefix.html:19:
}, 'A device name longer than 29 must reject.');
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> Same here, s/name/name prefix/

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/no-arguments.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/no-arguments.html:12:
}, 'Requires an argument.');
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> Probably "requestDevice() requires an argument."

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html:20:
}, 'Unicode string with utf8 representation between (29, 248] must throw ' +
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> "between (29, 248] bytes"?

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-namePrefix.html:20:
}, 'Unicode string with utf8 representation between (29, 248] must throw ' +
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> Distinguish this one from the 'name' variant too.

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-name-in-adv-name.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-name-in-adv-name.html:18:
}, 'Unicode string with utf8 representation greater than 248 must throw ' +
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> "greater than 248 bytes", I think.

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-name.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-name.html:7:
promise_test(() => {
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> This filename has a typo: lenght->length

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-name.html:9:
9, '\u2764'); // \u2764's UTF-8 representationis 3 bytes long.
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> s/representationis/representation is/

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-namePrefix.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-namePrefix.html:7:
promise_test(() => {
On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote:
> This filename also has a typo.

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-namePrefix.html:9:
9, '\u2764'); // \u2764's UTF-8 representationis 3 bytes long.
On 2016/05/09 at 22:09:57, Jeffrey Yasskin wrote:
> sp: representationis

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/discovery-succeeds.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/discovery-succeeds.html:11:
.then(() => requestDeviceWithKeyDown({
On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote:
> Comment why you can't do this in parallel. (Because Chrome would always close
one in the process of handling the user gesture for the next one, right?)

Yup. Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/processing-user-gesture.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/processing-user-gesture.html:8:
promise_test(() => {
On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote:
> This file is the same as
https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...;
you probably only need one.

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/bluetooth/requestDevice/single-filter-two-services-fails.html
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/bluetooth/requestDevice/single-filter-two-services-fails.html:9:
// Both devices support the Generic Access service, but things need to
On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote:
> s/Generic Access/Heart Rate/

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:309:
services = (services === undefined) ? ['heart_rate'] : services;
On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote:
> Make this an if statement:
> 
> if (services === undefined) {
>   services = ['heart_rate'];
> }

Used default argument instead.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:311:
filters: [{ services: services}]
On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote:
> Nit: Be symmetric with the spaces inside {}s: probably include 1 space on both
sides.

Done.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:335: //
to clean up this state after each test. Once the move to Mojo is complete
On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote:
> If this is the last change to split up tests, remove this at the same time?

We can't get rid of the adapter one yet because our service doesn't clean up the
adapter after each navigation yet. The next patch will remove the call to
setBluetoothFakeAdapter('').

[ortuno, 2016-05-11 19:29:43]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 19:30:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910933002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910933002/140001

[Jeffrey Yasskin, 2016-05-11 20:27:17]

lgtm

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
(right):

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:309:
services = (services === undefined) ? ['heart_rate'] : services;
On 2016/05/11 19:29:39, ortuno wrote:
> On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote:
> > Make this an if statement:
> > 
> > if (services === undefined) {
> >   services = ['heart_rate'];
> > }
> 
> Used default argument instead.

Oh, cool. Yay for new Javascript features.

https://codereview.chromium.org/1910933002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:335: //
to clean up this state after each test. Once the move to Mojo is complete
On 2016/05/11 19:29:39, ortuno wrote:
> On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote:
> > If this is the last change to split up tests, remove this at the same time?
> 
> We can't get rid of the adapter one yet because our service doesn't clean up
the
> adapter after each navigation yet. The next patch will remove the call to
> setBluetoothFakeAdapter('').

SG

[commit-bot: I haz the power, 2016-05-11 20:34:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 20:34:52]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-05-11 20:58:27]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-05-11 20:59:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910933002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910933002/140001

[commit-bot: I haz the power, 2016-05-11 21:07:39]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-05-11 21:26:12]

Description was changed from

==========
bluetooth: Separate requestDevice tests

BUG=554240
==========

to

==========
bluetooth: Separate requestDevice tests

BUG=554240

Committed: https://crrev.com/b5e139fd003e69025f2422d4a2635ac3a74cb153
Cr-Commit-Position: refs/heads/master@{#393060}
==========

[commit-bot: I haz the power, 2016-05-11 21:26:13]

Patchset 8 (id:??) landed as
https://crrev.com/b5e139fd003e69025f2422d4a2635ac3a74cb153
Cr-Commit-Position: refs/heads/master@{#393060}