Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1945723003: Remove WeakPtrFactory from PasswordAutofillAgent (Closed)

Created:
4 years, 7 months ago by vabr (Chromium)
Modified:
4 years, 7 months ago
Reviewers:
dvadym
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlistautofill_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WeakPtrFactory from PasswordAutofillAgent Unlike in AutofillAgent, the factory is no longer used in PAA. R=dvadym@chromium.org BUG=609010, 609007, 608100, 608101, 433486 Committed: https://crrev.com/9de81f45c73a8f9f215fc234a6adfe087b0eab74 Cr-Commit-Position: refs/heads/master@{#391475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M components/autofill/content/renderer/password_autofill_agent.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945723003/1
4 years, 7 months ago (2016-05-04 09:27:44 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 10:20:38 UTC) #4
vabr (Chromium)
Hi Vadym, PTAL. Thanks! Vaclav
4 years, 7 months ago (2016-05-04 10:32:05 UTC) #5
dvadym
On 2016/05/04 10:32:05, vabr (Chromium) wrote: > Hi Vadym, > > PTAL. > > Thanks! ...
4 years, 7 months ago (2016-05-04 10:38:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945723003/1
4 years, 7 months ago (2016-05-04 10:44:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 10:48:17 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 10:50:51 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9de81f45c73a8f9f215fc234a6adfe087b0eab74
Cr-Commit-Position: refs/heads/master@{#391475}

Powered by Google App Engine
This is Rietveld 408576698