Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 1945723003: Remove WeakPtrFactory from PasswordAutofillAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/password_autofill_agent.h" 5 #include "components/autofill/content/renderer/password_autofill_agent.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 631
632 } // namespace 632 } // namespace
633 633
634 //////////////////////////////////////////////////////////////////////////////// 634 ////////////////////////////////////////////////////////////////////////////////
635 // PasswordAutofillAgent, public: 635 // PasswordAutofillAgent, public:
636 636
637 PasswordAutofillAgent::PasswordAutofillAgent(content::RenderFrame* render_frame) 637 PasswordAutofillAgent::PasswordAutofillAgent(content::RenderFrame* render_frame)
638 : content::RenderFrameObserver(render_frame), 638 : content::RenderFrameObserver(render_frame),
639 logging_state_active_(false), 639 logging_state_active_(false),
640 was_username_autofilled_(false), 640 was_username_autofilled_(false),
641 was_password_autofilled_(false), 641 was_password_autofilled_(false) {
642 weak_ptr_factory_(this) {
643 Send(new AutofillHostMsg_PasswordAutofillAgentConstructed(routing_id())); 642 Send(new AutofillHostMsg_PasswordAutofillAgentConstructed(routing_id()));
644 } 643 }
645 644
646 PasswordAutofillAgent::~PasswordAutofillAgent() { 645 PasswordAutofillAgent::~PasswordAutofillAgent() {
647 } 646 }
648 647
649 PasswordAutofillAgent::PasswordValueGatekeeper::PasswordValueGatekeeper() 648 PasswordAutofillAgent::PasswordValueGatekeeper::PasswordValueGatekeeper()
650 : was_user_gesture_seen_(false) { 649 : was_user_gesture_seen_(false) {
651 } 650 }
652 651
(...skipping 882 matching lines...) Expand 10 before | Expand all | Expand 10 after
1535 } 1534 }
1536 1535
1537 bool PasswordAutofillAgent::ProvisionallySavedPasswordIsValid() { 1536 bool PasswordAutofillAgent::ProvisionallySavedPasswordIsValid() {
1538 return provisionally_saved_form_ && 1537 return provisionally_saved_form_ &&
1539 !provisionally_saved_form_->username_value.empty() && 1538 !provisionally_saved_form_->username_value.empty() &&
1540 !(provisionally_saved_form_->password_value.empty() && 1539 !(provisionally_saved_form_->password_value.empty() &&
1541 provisionally_saved_form_->new_password_value.empty()); 1540 provisionally_saved_form_->new_password_value.empty());
1542 } 1541 }
1543 1542
1544 } // namespace autofill 1543 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698