Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1945063003: clang/win: Reenable incremental linking. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Reenable incremental linking. llvm r268331 let clang-cl reate a unique .pdata section for every .text section, which should unconfuse link.exe. This reverts https://codereview.chromium.org/1884973002 BUG=595702 Committed: https://crrev.com/5541c6da402958f5b3c77cf628f4e4bf45b7bda6 Cr-Commit-Position: refs/heads/master@{#391677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M build/config/win/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945063003/1
4 years, 7 months ago (2016-05-04 21:17:57 UTC) #2
Nico
4 years, 7 months ago (2016-05-04 21:18:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 22:27:49 UTC) #7
Reid Kleckner
lgtm
4 years, 7 months ago (2016-05-04 22:49:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945063003/1
4 years, 7 months ago (2016-05-04 23:01:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 23:05:41 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 23:06:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5541c6da402958f5b3c77cf628f4e4bf45b7bda6
Cr-Commit-Position: refs/heads/master@{#391677}

Powered by Google App Engine
This is Rietveld 408576698