Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1884973002: clang/win: Disable incremental linking. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Disable incremental linking. MSVC 2015's linker regressed incremental linking with clang, so turn it off for now. Going forward, hopefully we can get that fixed, or we can switch to linking with lld. BUG=595702 TBR=dpranke Committed: https://chromium.googlesource.com/chromium/src/+/9f230704fde72e9ae4a7a023b6e6c3d8666e920f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/config/win/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Nico
The LLD plan didn't work out in the near term (https://bugs.chromium.org/p/chromium/issues/detail?id=595702#c36), so let's try this ...
4 years, 8 months ago (2016-04-13 13:17:49 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9f230704fde72e9ae4a7a023b6e6c3d8666e920f Cr-Commit-Position: refs/heads/master@{#386978}
4 years, 8 months ago (2016-04-13 13:41:25 UTC) #6
Nico
Committed patchset #1 (id:1) manually as 9f230704fde72e9ae4a7a023b6e6c3d8666e920f (presubmit successful).
4 years, 8 months ago (2016-04-13 13:42:12 UTC) #8
Reid Kleckner
4 years, 8 months ago (2016-04-13 16:53:19 UTC) #9
Message was sent while issue was closed.
What about GYP? I guess this fixes the trybot and gn is coming soon enough that
we don't have to worry about gyp?

Powered by Google App Engine
This is Rietveld 408576698