Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: build/config/win/BUILD.gn

Issue 1945063003: clang/win: Reenable incremental linking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/compiler/compiler.gni") 5 import("//build/config/compiler/compiler.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 6 import("//build/config/sanitizers/sanitizers.gni")
7 import("//build/config/win/visual_studio_version.gni") 7 import("//build/config/win/visual_studio_version.gni")
8 import("//build/toolchain/toolchain.gni") 8 import("//build/toolchain/toolchain.gni")
9 9
10 assert(is_win) 10 assert(is_win)
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 } 310 }
311 config("windowed") { 311 config("windowed") {
312 ldflags = [ "/SUBSYSTEM:WINDOWS$subsystem_version_suffix" ] 312 ldflags = [ "/SUBSYSTEM:WINDOWS$subsystem_version_suffix" ]
313 } 313 }
314 314
315 # Incremental linking ---------------------------------------------------------- 315 # Incremental linking ----------------------------------------------------------
316 316
317 incremental_linking_on_switch = [ "/INCREMENTAL" ] 317 incremental_linking_on_switch = [ "/INCREMENTAL" ]
318 incremental_linking_off_switch = [ "/INCREMENTAL:NO" ] 318 incremental_linking_off_switch = [ "/INCREMENTAL:NO" ]
319 319
320 # MSVC2015's incremental linker complains about clang's .obj files sometimes,
321 # https://crbug.com/595702. Disable incremental linking with clang for now.
322 # TODO(thakis): Remove this once that problem is fixed, or when the win_clang
323 # bot uses lld.
324 # Disable incremental linking for syzyasan 320 # Disable incremental linking for syzyasan
325 if (is_debug && !is_clang && !is_syzyasan) { 321 if (is_debug && !is_syzyasan) {
326 default_incremental_linking_switch = incremental_linking_on_switch 322 default_incremental_linking_switch = incremental_linking_on_switch
327 } else { 323 } else {
328 default_incremental_linking_switch = incremental_linking_off_switch 324 default_incremental_linking_switch = incremental_linking_off_switch
329 } 325 }
330 326
331 # Applies incremental linking or not depending on the current configuration. 327 # Applies incremental linking or not depending on the current configuration.
332 config("default_incremental_linking") { 328 config("default_incremental_linking") {
333 ldflags = default_incremental_linking_switch 329 ldflags = default_incremental_linking_switch
334 } 330 }
335 331
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 397
402 # Internal stuff -------------------------------------------------------------- 398 # Internal stuff --------------------------------------------------------------
403 399
404 # Config used by the MIDL template to disable warnings. 400 # Config used by the MIDL template to disable warnings.
405 config("midl_warnings") { 401 config("midl_warnings") {
406 if (is_clang) { 402 if (is_clang) {
407 # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_". 403 # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
408 cflags = [ "-Wno-extra-tokens" ] 404 cflags = [ "-Wno-extra-tokens" ]
409 } 405 }
410 } 406 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698