Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1944703002: [keys] Cleanup: removing unused parameters in elements.cc and keys.cc (Closed)

Created:
4 years, 7 months ago by Camillo Bruni
Modified:
4 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@2016-04-19_keys.cc_the_great_migration_1938413002
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[keys] Cleanup: removing unused parameters in elements.cc and keys.cc - Cleanup CL to remove unused parameters in elements.cc. Additionally use fields from the KeyAccumulator wherever possible. - Make method names in KeyAccumulator more consistent BUG= Committed: https://crrev.com/e801d554aa30b034b191246fb02a1856165899e3 Cr-Commit-Position: refs/heads/master@{#36073}

Patch Set 1 #

Patch Set 2 : more cleanup #

Patch Set 3 : addressing comments #

Patch Set 4 : messing around #

Patch Set 5 : cleanup #

Patch Set 6 : remove accidental changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -83 lines) Patch
M src/elements.h View 2 chunks +4 lines, -11 lines 0 comments Download
M src/elements.cc View 5 chunks +16 lines, -29 lines 0 comments Download
M src/keys.h View 1 2 chunks +15 lines, -17 lines 0 comments Download
M src/keys.cc View 1 2 3 6 chunks +23 lines, -23 lines 0 comments Download
M src/objects.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944703002/40001
4 years, 7 months ago (2016-05-04 14:30:40 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/17178) v8_linux64_avx2_rel_ng on ...
4 years, 7 months ago (2016-05-04 14:32:58 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944703002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944703002/100001
4 years, 7 months ago (2016-05-06 09:24:25 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 09:53:58 UTC) #10
Camillo Bruni
PTAL
4 years, 7 months ago (2016-05-06 09:54:54 UTC) #12
Igor Sheludko
lgtm
4 years, 7 months ago (2016-05-06 10:09:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944703002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944703002/100001
4 years, 7 months ago (2016-05-06 10:48:46 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-06 10:50:47 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 10:51:47 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e801d554aa30b034b191246fb02a1856165899e3
Cr-Commit-Position: refs/heads/master@{#36073}

Powered by Google App Engine
This is Rietveld 408576698