Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: src/elements.h

Issue 1944703002: [keys] Cleanup: removing unused parameters in elements.cc and keys.cc (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2016-04-19_keys.cc_the_great_migration_1938413002
Patch Set: remove accidental changes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index 2b18ab07d12066cfb53fde8f8501b8698d6af752..d6716fcba4da69b3a74ec25ffcaca201123ca9d9 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -81,18 +81,12 @@ class ElementsAccessor {
// whose PropertyAttribute match |filter|.
virtual void CollectElementIndices(Handle<JSObject> object,
Handle<FixedArrayBase> backing_store,
- KeyAccumulator* keys,
- uint32_t range = kMaxUInt32,
- PropertyFilter filter = ALL_PROPERTIES,
- uint32_t offset = 0) = 0;
+ KeyAccumulator* keys) = 0;
inline void CollectElementIndices(Handle<JSObject> object,
- KeyAccumulator* keys,
- uint32_t range = kMaxUInt32,
- PropertyFilter filter = ALL_PROPERTIES,
- uint32_t offset = 0) {
- CollectElementIndices(object, handle(object->elements()), keys, range,
- filter, offset);
+ KeyAccumulator* keys) {
+ CollectElementIndices(object, handle(object->elements(), keys->isolate()),
+ keys);
}
virtual Maybe<bool> CollectValuesOrEntries(
@@ -100,7 +94,6 @@ class ElementsAccessor {
Handle<FixedArray> values_or_entries, bool get_entries, int* nof_items,
PropertyFilter filter = ALL_PROPERTIES) = 0;
- //
virtual Handle<FixedArray> PrependElementIndices(
Handle<JSObject> object, Handle<FixedArrayBase> backing_store,
Handle<FixedArray> keys, GetKeysConversion convert,
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698