Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1863543002: Setting Symbol.length to 0 according to the spec (Closed)

Created:
4 years, 8 months ago by Camillo Bruni
Modified:
4 years, 8 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Setting Symbol.length to 0 according to the spec BUG=v8:4882 LOG=n Committed: https://crrev.com/47e0a39246397df6ac8a2ad5df82619746f8ca0c Cr-Commit-Position: refs/heads/master@{#35255}

Patch Set 1 #

Messages

Total messages: 13 (6 generated)
Camillo Bruni
PTAL
4 years, 8 months ago (2016-04-05 07:44:03 UTC) #2
Dan Ehrenberg
lgtm
4 years, 8 months ago (2016-04-05 07:44:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863543002/1
4 years, 8 months ago (2016-04-05 09:32:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13204)
4 years, 8 months ago (2016-04-05 09:35:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863543002/1
4 years, 8 months ago (2016-04-05 10:54:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 10:56:22 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 10:57:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47e0a39246397df6ac8a2ad5df82619746f8ca0c
Cr-Commit-Position: refs/heads/master@{#35255}

Powered by Google App Engine
This is Rietveld 408576698