Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1944553002: Fix IT2Me protocol error connecting to old hosts. (Closed)

Created:
4 years, 7 months ago by Jamie
Modified:
4 years, 7 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix IT2Me protocol error connecting to old hosts. This is a revert of the client-side changes introduced in https://codereview.chromium.org/1799293002. Pre-M51 IT2Me hosts do not support anything except spake2-plain, so M51 and later clients cannot connect to them BUG=607643 Committed: https://crrev.com/5c5aec85e2efd5777723c61b3b13b59f6f235331 Cr-Commit-Position: refs/heads/master@{#391140}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reviewer feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M remoting/protocol/negotiating_authenticator_base.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_base.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/protocol/negotiating_client_authenticator.cc View 3 chunks +7 lines, -1 line 0 comments Download
M remoting/protocol/negotiating_host_authenticator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jamie
PTAL
4 years, 7 months ago (2016-05-02 23:45:46 UTC) #2
kelvinp
lgtm https://codereview.chromium.org/1944553002/diff/1/remoting/protocol/negotiating_authenticator_base.h File remoting/protocol/negotiating_authenticator_base.h (right): https://codereview.chromium.org/1944553002/diff/1/remoting/protocol/negotiating_authenticator_base.h#newcode71 remoting/protocol/negotiating_authenticator_base.h:71: // TODO(sergeyu): Remove and use SHARED_SECRET_SPAKE2_CURVE25519. Maybe update ...
4 years, 7 months ago (2016-05-03 00:22:36 UTC) #3
Jamie
FYI https://codereview.chromium.org/1944553002/diff/1/remoting/protocol/negotiating_authenticator_base.h File remoting/protocol/negotiating_authenticator_base.h (right): https://codereview.chromium.org/1944553002/diff/1/remoting/protocol/negotiating_authenticator_base.h#newcode71 remoting/protocol/negotiating_authenticator_base.h:71: // TODO(sergeyu): Remove and use SHARED_SECRET_SPAKE2_CURVE25519. On 2016/05/03 ...
4 years, 7 months ago (2016-05-03 00:33:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944553002/20001
4 years, 7 months ago (2016-05-03 00:33:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 01:21:20 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 01:22:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c5aec85e2efd5777723c61b3b13b59f6f235331
Cr-Commit-Position: refs/heads/master@{#391140}

Powered by Google App Engine
This is Rietveld 408576698