Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1799293002: Remove spake2_plain authentication method. (Closed)

Created:
4 years, 9 months ago by Sergey Ulanov
Modified:
4 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pair_spake
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove spake2_plain authentication method. It2me host can use spake2_hmac authentication method and it works properly with the current client, so there is no reason to keep spake2_plain for It2Me. Committed: https://crrev.com/d5d7539fdbcb87afac1d6b25347fb1246b500ad0 Cr-Commit-Position: refs/heads/master@{#381744}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -105 lines) Patch
M remoting/host/it2me/it2me_host.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/negotiating_authenticator_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_base.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_unittest.cc View 9 chunks +30 lines, -53 lines 0 comments Download
M remoting/protocol/negotiating_client_authenticator.cc View 3 chunks +1 line, -7 lines 0 comments Download
M remoting/protocol/negotiating_host_authenticator.h View 1 chunk +4 lines, -12 lines 0 comments Download
M remoting/protocol/negotiating_host_authenticator.cc View 2 chunks +3 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
Sergey Ulanov
4 years, 9 months ago (2016-03-14 22:49:12 UTC) #3
Jamie
lgtm
4 years, 9 months ago (2016-03-15 00:25:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799293002/20001
4 years, 9 months ago (2016-03-17 06:52:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/5567) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-17 06:54:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799293002/40001
4 years, 9 months ago (2016-03-17 17:24:41 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-17 18:08:13 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 18:09:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5d7539fdbcb87afac1d6b25347fb1246b500ad0
Cr-Commit-Position: refs/heads/master@{#381744}

Powered by Google App Engine
This is Rietveld 408576698