Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: remoting/protocol/negotiating_authenticator_base.h

Issue 1944553002: Fix IT2Me protocol error connecting to old hosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer feedback. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/protocol/negotiating_authenticator_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/negotiating_authenticator_base.h
diff --git a/remoting/protocol/negotiating_authenticator_base.h b/remoting/protocol/negotiating_authenticator_base.h
index b5ff31cd4a6f0d4b2660f78852cb3d318770fadd..1f42cfa3f8803538b3b9550eb01d53b2c0cccd2f 100644
--- a/remoting/protocol/negotiating_authenticator_base.h
+++ b/remoting/protocol/negotiating_authenticator_base.h
@@ -67,6 +67,12 @@ class NegotiatingAuthenticatorBase : public Authenticator {
enum class Method {
INVALID,
+ // SPAKE2 with P224 using access code in plain-text. Used for It2Me.
+ // TODO(sergeyu): Remove and use SHARED_SECRET_SPAKE2_CURVE25519 once
+ // the population of M50 hosts (which require this for IT2Me) is
+ // sufficiently low: crbug.com/607643.
+ SHARED_SECRET_PLAIN_SPAKE2_P224,
+
// SPAKE2 PIN or access code hashed with host_id using HMAC-SHA256.
SHARED_SECRET_SPAKE2_P224,
SHARED_SECRET_SPAKE2_CURVE25519,
« no previous file with comments | « no previous file | remoting/protocol/negotiating_authenticator_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698