Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1944413002: [Interpreter]: Unskip some tests which pass with --ignition and group other failures. (Closed)

Created:
4 years, 7 months ago by rmcilroy
Modified:
4 years, 7 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter]: Unskip some tests which pass with --ignition and group other failures. Some tests which fail with '--ignition --turbo --turbo-from-bytecode' pass with just '--ignition'. Unskip these tests. Also group other tests with related bugs. BUG=v8:4680 LOG=N Committed: https://crrev.com/c2c2d8e69cc4023abae07637464d0be43a89b724 Cr-Commit-Position: refs/heads/master@{#36083}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -69 lines) Patch
M test/cctest/cctest.status View 3 chunks +5 lines, -35 lines 0 comments Download
M test/mjsunit/ignition/elided-instruction.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/ignition/elided-instruction-no-ignition.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 8 chunks +10 lines, -32 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944413002/1
4 years, 7 months ago (2016-05-04 16:36:25 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1177) v8_mac_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-04 16:52:56 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944413002/20001
4 years, 7 months ago (2016-05-04 22:27:07 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 22:54:20 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944413002/40001
4 years, 7 months ago (2016-05-06 10:19:46 UTC) #10
rmcilroy
Orion, PTAL, thanks.
4 years, 7 months ago (2016-05-06 10:19:54 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 10:48:16 UTC) #14
oth
lgtm
4 years, 7 months ago (2016-05-06 13:53:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944413002/40001
4 years, 7 months ago (2016-05-06 14:00:46 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-06 14:03:07 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 14:04:41 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c2c2d8e69cc4023abae07637464d0be43a89b724
Cr-Commit-Position: refs/heads/master@{#36083}

Powered by Google App Engine
This is Rietveld 408576698