[Interpreter] Fix incorrect frame walking in arguments create stubs

[Interpreter] Fix incorrect frame walking in arguments create stubs

The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
looked at the function slot in order to skip stub frames
and find the JS frame. However, stub frames do not have a
function slot (in fact their fixed frame ends one slot
before the JS frame's function slot). Therefore, if this
location in the stub frame happens to have the function
object the create arguments stubs won't skip this frame
correctly.

Replace this approach with one where the stub is
specialized to either skip a frame if required (since
there will only ever be one extra frame on Ignition
the loop approach isn't necessary).

BUG=v8:4928
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg

Committed: https://crrev.com/40f345416f00761c79b9d2094c2e12e798329935
Cr-Commit-Position: refs/heads/master@{#36181}

[rmcilroy, 2016-05-04 12:35:45]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 12:35:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949023003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949023003/1

[commit-bot: I haz the power, 2016-05-04 14:15:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 14:15:32]

Dry run: Try jobs failed on following builders:
  v8_linux_nosnap_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nosnap_dbg/builds/...)

[rmcilroy, 2016-05-06 10:47:32]

Description was changed from

==========
[Interpreter] Unskip InterpreterCreateArguments which no longer fails.

InterpreterCreateArguments no longer seems to fail on the bots, unskip it.

BUG=v8:4928
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
==========

to

==========
[Interpreter] Fix incorrect frame walking in arguments create stubs

The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
looked at the function slot in order to skip stub frames
and find the JS frame. However, stub frames do not have a
function slot (in fact their fixed frame ends one slot
before the JS frame's function slot). Therefore, if this 
location in the stub frame happens to have the function
object the create arguments stubs won't skip this frame
correctly.

Replace this approach with one where the stub is 
specialized to either skip a frame if required (since 
there will only ever be one extra frame on Ignition
the loop approach isn't necessary).

BUG=v8:4928
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
==========

[rmcilroy, 2016-05-06 10:47:45]

Patchset #6 (id:100001) has been deleted

[rmcilroy, 2016-05-06 10:47:51]

Patchset #5 (id:80001) has been deleted

[rmcilroy, 2016-05-06 10:47:56]

Patchset #4 (id:60001) has been deleted

[rmcilroy, 2016-05-06 10:48:01]

Patchset #3 (id:40001) has been deleted

[rmcilroy, 2016-05-06 10:48:06]

Patchset #2 (id:20001) has been deleted

[rmcilroy, 2016-05-06 10:48:13]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-05-06 10:49:06]

rmcilroy@chromium.org changed reviewers:
+ bmeurer@chromium.org

[rmcilroy, 2016-05-06 10:49:07]

Benedkit, could you have a look please. If reasonable I'll port to other
architectures.

[rmcilroy, 2016-05-09 09:59:13]

Ping Benedkit?

[Benedikt Meurer, 2016-05-09 10:14:03]

lgtm

[rmcilroy, 2016-05-11 14:05:44]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 14:05:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949023003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949023003/180001

[commit-bot: I haz the power, 2016-05-11 15:00:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 15:00:03]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-05-11 15:04:19]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-05-11 15:04:19]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1949023003/#ps180001
(title: "Add ports")

[commit-bot: I haz the power, 2016-05-11 15:04:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949023003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949023003/180001

[commit-bot: I haz the power, 2016-05-11 15:06:48]

Description was changed from

==========
[Interpreter] Fix incorrect frame walking in arguments create stubs

The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
looked at the function slot in order to skip stub frames
and find the JS frame. However, stub frames do not have a
function slot (in fact their fixed frame ends one slot
before the JS frame's function slot). Therefore, if this 
location in the stub frame happens to have the function
object the create arguments stubs won't skip this frame
correctly.

Replace this approach with one where the stub is 
specialized to either skip a frame if required (since 
there will only ever be one extra frame on Ignition
the loop approach isn't necessary).

BUG=v8:4928
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
==========

to

==========
[Interpreter] Fix incorrect frame walking in arguments create stubs

The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
looked at the function slot in order to skip stub frames
and find the JS frame. However, stub frames do not have a
function slot (in fact their fixed frame ends one slot
before the JS frame's function slot). Therefore, if this 
location in the stub frame happens to have the function
object the create arguments stubs won't skip this frame
correctly.

Replace this approach with one where the stub is 
specialized to either skip a frame if required (since 
there will only ever be one extra frame on Ignition
the loop approach isn't necessary).

BUG=v8:4928
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
==========

[commit-bot: I haz the power, 2016-05-11 15:06:49]

Committed patchset #4 (id:180001)

[commit-bot: I haz the power, 2016-05-11 15:07:58]

Description was changed from

==========
[Interpreter] Fix incorrect frame walking in arguments create stubs

The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
looked at the function slot in order to skip stub frames
and find the JS frame. However, stub frames do not have a
function slot (in fact their fixed frame ends one slot
before the JS frame's function slot). Therefore, if this 
location in the stub frame happens to have the function
object the create arguments stubs won't skip this frame
correctly.

Replace this approach with one where the stub is 
specialized to either skip a frame if required (since 
there will only ever be one extra frame on Ignition
the loop approach isn't necessary).

BUG=v8:4928
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
==========

to

==========
[Interpreter] Fix incorrect frame walking in arguments create stubs

The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
looked at the function slot in order to skip stub frames
and find the JS frame. However, stub frames do not have a
function slot (in fact their fixed frame ends one slot
before the JS frame's function slot). Therefore, if this
location in the stub frame happens to have the function
object the create arguments stubs won't skip this frame
correctly.

Replace this approach with one where the stub is
specialized to either skip a frame if required (since
there will only ever be one extra frame on Ignition
the loop approach isn't necessary).

BUG=v8:4928
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg

Committed: https://crrev.com/40f345416f00761c79b9d2094c2e12e798329935
Cr-Commit-Position: refs/heads/master@{#36181}
==========

[commit-bot: I haz the power, 2016-05-11 15:07:59]

Patchset 4 (id:??) landed as
https://crrev.com/40f345416f00761c79b9d2094c2e12e798329935
Cr-Commit-Position: refs/heads/master@{#36181}