Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: test/cctest/cctest.status

Issue 1944413002: [Interpreter]: Unskip some tests which pass with --ignition and group other failures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/ignition/elided-instruction.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index e0ee04e652d65051b6c1c094afaf8fbdefccbba8..00e3be36913c0481feac83193bcbe0a9ebab1d7f 100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -136,17 +136,13 @@
############################################################################
# Ignition
- # TODO(rmcilroy,4680): Check failed: !function->shared()->is_compiled() || function->IsOptimized().
+ # TODO(rmcilroy,4680): Related to lack of code flushing. Check failed: !function->shared()->is_compiled() || function->IsOptimized().
'test-heap/TestCodeFlushingPreAged': [PASS, NO_IGNITION],
'test-heap/TestCodeFlushingIncrementalScavenge': [PASS, NO_IGNITION],
'test-heap/TestCodeFlushing': [PASS, NO_IGNITION],
'test-heap/TestCodeFlushingIncremental': [PASS, NO_IGNITION],
'test-heap/TestCodeFlushingIncrementalAbort': [PASS, ['mode == debug or dcheck_always_on == True', NO_IGNITION]],
- # TODO(rmcilroy,4766): Requires BytecodeGraphBuilder to track source position
- # on nodes (behind --turbo_source_positions flag).
- 'test-cpu-profiler/TickLinesOptimized': [PASS, NO_IGNITION],
-
# TODO(rmcilroy,4680): Fails to find the correct function name for the
# anonymous function. Fails without ignition but with --no-lazy also, so seems
# to be an issue when eagerly parsing.
@@ -176,38 +172,12 @@
# TODO(mvstanton,4900): CHECK(!g_function->is_compiled());
'test-heap/TestUseOfIncrementalBarrierOnCompileLazy': [PASS, NO_IGNITION],
- # TODO(rmcilroy,4837): We don't set a LoadContextSlot for a function as
- # immutable in the BytecodeGraphBuilder, therefore no inlining happens.
- 'test-run-inlining/InlineLoopGuardedTwice': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineSurplusArgumentsDeopt': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineTwice': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineSurplusArgumentsObject': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineTwiceDependentDiamond': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineWithArguments': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineLoopUnguardedTwice': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineOmitArgumentsObject': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineLoopUnguardedOnce': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineOmitArgumentsDeopt': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineTwiceDependentDiamondDifferent': [PASS, NO_IGNITION],
- 'test-run-inlining/SimpleInliningContext': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineMutuallyRecursive': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineLoopGuardedEmpty': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineLoopGuardedOnce': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineOmitArguments': [PASS, NO_IGNITION],
- 'test-run-inlining/SimpleInlining': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineLoopUnguardedEmpty': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineNestedBuiltin': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineSurplusArguments': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineBuiltin': [PASS, NO_IGNITION],
- 'test-run-inlining/InlineTwiceDependent': [PASS, NO_IGNITION],
- 'test-run-inlining/SimpleInliningContextDeopt': [PASS, NO_IGNITION],
+ # BUG(rmcilroy,4680): Function is optimized without type feedback and so immediately deopts again, causing check failure in the test.
+ 'test-heap/ResetSharedFunctionInfoCountersDuringIncrementalMarking': [PASS, NO_IGNITION],
+ 'test-heap/ResetSharedFunctionInfoCountersDuringMarkSweep': [PASS, NO_IGNITION],
# BUG(4751). Flaky with ignition and tsan.
'test-cpu-profiler/JsNativeJsSample': [PASS, ['tsan', NO_IGNITION]],
-
- 'test-cpu-profiler/Inlining': [PASS, NO_IGNITION],
- 'test-heap/ResetSharedFunctionInfoCountersDuringIncrementalMarking': [PASS, NO_IGNITION],
- 'test-heap/ResetSharedFunctionInfoCountersDuringMarkSweep': [PASS, NO_IGNITION],
}], # ALWAYS
##############################################################################
@@ -569,7 +539,7 @@
##############################################################################
['ignition or ignition_turbofan', {
- # TODO(rmcilroy,4680): Check failed: !function->shared()->is_compiled() || function->IsOptimized().
+ # TODO(rmcilroy,4680): Related to lack of code flushing. Check failed: !function->shared()->is_compiled() || function->IsOptimized().
'test-heap/TestCodeFlushingPreAged': [FAIL],
'test-heap/TestCodeFlushingIncrementalScavenge': [FAIL],
'test-heap/TestCodeFlushing': [FAIL],
« no previous file with comments | « no previous file | test/mjsunit/ignition/elided-instruction.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698