Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 1943993005: Remove wildcard usage in interface lists (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, kalyank, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sadrul, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove wildcard usage in interface lists. I still have to allow passing wildcards in allowed_interfaces via AcceptConnection, since I think it's valid to define a class that exports all interfaces. So the enforcement here is in the manifest reading, making sure it's never set as a value for interfaces. R=rockot@chromium.org Committed: https://crrev.com/89a6f082f940a7c170db1bba7d4cfc606cfcca82 Cr-Commit-Position: refs/heads/master@{#391896}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -38 lines) Patch
M components/mus/demo/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gpu/mus_gpu_unittests_app_manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +2 lines, -3 lines 0 comments Download
M mash/init/init.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mash/init/init.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M mash/init/manifest.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M mash/session/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/unittests_manifest.json View 1 2 3 4 5 1 chunk +7 lines, -3 lines 0 comments Download
A services/catalog/data/wildcard_interfaces View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M services/catalog/entry.cc View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M services/catalog/entry_unittest.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M services/shell/background/tests/test_catalog_store.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M services/shell/tests/connect/connect_test_app_manifest.json View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M services/shell/tests/connect/connect_unittests_manifest.json View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M services/shell/tests/lifecycle/exe_manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/lifecycle/lifecycle_unittest_manifest.json View 1 2 1 chunk +11 lines, -4 lines 0 comments Download
M services/shell/tests/shell/driver_manifest.json View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/tests/shell/shell_unittest_manifest.json View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M services/user/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/unittests_manifest.json View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ben Goodger (Google)
4 years, 7 months ago (2016-05-05 16:48:10 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-05 18:15:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943993005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943993005/100001
4 years, 7 months ago (2016-05-05 18:18:10 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-05 20:31:00 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 20:33:07 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/89a6f082f940a7c170db1bba7d4cfc606cfcca82
Cr-Commit-Position: refs/heads/master@{#391896}

Powered by Google App Engine
This is Rietveld 408576698