Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: services/shell/background/tests/test_catalog_store.cc

Issue 1943993005: Remove wildcard usage in interface lists (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/catalog/entry_unittest.cc ('k') | services/shell/public/cpp/lib/interface_registry.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/shell/background/tests/test_catalog_store.h" 5 #include "services/shell/background/tests/test_catalog_store.h"
6 6
7 using catalog::Store; 7 using catalog::Store;
8 8
9 namespace shell { 9 namespace shell {
10 10
(...skipping 17 matching lines...) Expand all
28 app->SetString(Store::kDisplayNameKey, display_name); 28 app->SetString(Store::kDisplayNameKey, display_name);
29 app->SetInteger(Store::kManifestVersionKey, 1); 29 app->SetInteger(Store::kManifestVersionKey, 1);
30 30
31 std::unique_ptr<base::DictionaryValue> capabilities( 31 std::unique_ptr<base::DictionaryValue> capabilities(
32 new base::DictionaryValue); 32 new base::DictionaryValue);
33 std::unique_ptr<base::DictionaryValue> required_capabilities( 33 std::unique_ptr<base::DictionaryValue> required_capabilities(
34 new base::DictionaryValue); 34 new base::DictionaryValue);
35 std::unique_ptr<base::DictionaryValue> interfaces_dictionary( 35 std::unique_ptr<base::DictionaryValue> interfaces_dictionary(
36 new base::DictionaryValue); 36 new base::DictionaryValue);
37 std::unique_ptr<base::ListValue> interfaces_list(new base::ListValue); 37 std::unique_ptr<base::ListValue> interfaces_list(new base::ListValue);
38 interfaces_list->AppendString("*"); 38 interfaces_list->AppendString("shell::mojom::TestService");
39 interfaces_dictionary->Set("interfaces", std::move(interfaces_list)); 39 interfaces_dictionary->Set("interfaces", std::move(interfaces_list));
40 required_capabilities->Set("*", std::move(interfaces_dictionary)); 40 required_capabilities->Set("*", std::move(interfaces_dictionary));
41 capabilities->Set(Store::kCapabilities_RequiredKey, 41 capabilities->Set(Store::kCapabilities_RequiredKey,
42 std::move(required_capabilities)); 42 std::move(required_capabilities));
43 app->Set(Store::kCapabilitiesKey, std::move(capabilities)); 43 app->Set(Store::kCapabilitiesKey, std::move(capabilities));
44 return app; 44 return app;
45 } 45 }
46 46
47 } // namespace shell 47 } // namespace shell
OLDNEW
« no previous file with comments | « services/catalog/entry_unittest.cc ('k') | services/shell/public/cpp/lib/interface_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698