services/shell/background/tests/test_catalog_store.cc - Issue 1943993005: Remove wildcard usage in interface lists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/background/tests/test_catalog_store.cc

Issue 1943993005: Remove wildcard usage in interface lists (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/shell/background/tests/test_catalog_store.cc

diff --git a/services/shell/background/tests/test_catalog_store.cc b/services/shell/background/tests/test_catalog_store.cc

index aa2f2795970eb39accade6b3b0b38d8b58324767..57b450f4093e3663b62da983f2d78d6093c3eaa4 100644

--- a/services/shell/background/tests/test_catalog_store.cc

+++ b/services/shell/background/tests/test_catalog_store.cc

@@ -35,7 +35,7 @@ std::unique_ptr<base::DictionaryValue> BuildPermissiveSerializedAppInfo(

std::unique_ptr<base::DictionaryValue> interfaces_dictionary(

new base::DictionaryValue);

std::unique_ptr<base::ListValue> interfaces_list(new base::ListValue);

- interfaces_list->AppendString("*");

+ interfaces_list->AppendString("shell::mojom::TestService");

interfaces_dictionary->Set("interfaces", std::move(interfaces_list));

required_capabilities->Set("*", std::move(interfaces_dictionary));

capabilities->Set(Store::kCapabilities_RequiredKey,